fix: throttle color controls and make updateArgs
and resetArgs
stable
#18335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Fix a bug where Color controls are not throttled properly and causing sluggish preview
This is mainly caused by:
updateArgs
andresetArgs
is not stable (It depends ondata
/story
which contains reference toargs
, so it is re-created everytime args is updated)throttle
for ColorControl is not called inside a memo functionTo reproduce, go to this story https://storybookjs.netlify.app/official-storybook/?path=/story/addons-controls-sort--none and try to move around the color picker of the
color
control fast enough, the speed of re-rendering is too slow to catch up.How to test
If your answer is yes to any of these, please make sure to include it in your PR.