Build: Swap order of e2e tests around

[ndelangen]

Issue: e2e pnp tests are failing

What I did

• swap order of e2e tests around

this makes them pass, we think that perhaps some tests are leaking into each other.
We plan to migrate off of cypress in the future,
so I'm not going to spend more time on improving this.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 450fb4a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[yannbf]

why is this necessary in addon-docs?

[yannbf]

Nice stuff @ndelangen <3

[shilman]

awesome 👏

[ndelangen]

Just for future reference, turns out that there's a something not quite right here:

storybook/cypress/support/commands.js

Lines 101 to 110 in 450fb4a

	if (name !== 'page') {
	// Section might be collapsed
	cy.get(`#${kindId}`).then(async ($item) => {
	if ($item.attr('aria-expanded') === 'false') {
	await $item.click();
	// eslint-disable-next-line cypress/no-unnecessary-waiting
	cy.wait(300);
	}
	});
	}

There seems to be some order of operation error, and that's the true cause some tests aren't passing.. the wrong story is selected, and thus (as one would expect) the test fails.

By waiting a bit longer, the story is correctly selected, and the test proceeds as designed...