Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a feature flag for enabling crossOriginIsolated #17815

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

ndelangen
Copy link
Member

What I did

I added a feature flag to enabling the header to get SharedArrayBuffer to work.
We need to make this opt-in because it broke some storybooks

@ndelangen ndelangen requested a review from tmeasday March 29, 2022 08:57
@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4fe2760. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Mar 29, 2022
@ndelangen ndelangen added the bug label Mar 29, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder if it should be a core option?

@ndelangen
Copy link
Member Author

what's the rationale behind features vs core? It feels a little bit arbitrary.

@shilman
Copy link
Member

shilman commented Mar 29, 2022

@ndelangen @tmeasday

My thinking is that feature flags are a temporary mechanism by which we turn code on and off to:

  • to make breaking changes available in minor releases
  • temporarily support legacy options that we plan to remove
  • piloting experimental features

Code to configure other aspects of storybook should be located elsewhere. I think this one should go in core.

@ndelangen
Copy link
Member Author

I changed it to be in core

@ndelangen ndelangen merged commit 21c0f45 into next Mar 29, 2022
@ndelangen ndelangen deleted the tech/feature-flag-crossOriginIsolated branch March 29, 2022 17:55
@tmeasday
Copy link
Member

That's what I suspected. Thanks for clarifying @shilman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants