Core: Ensure that we do not render a story twice if re-rendered during preparing #17599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 539c868. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
force-pushed
the
refactor-story-render
branch
from
397d4f8 to
338d516
Compare
tmeasday
force-pushed
the
17214-fix-duplicate-initial-render
branch
from
f2848ec to
8214d06
Compare
shilman
approved these changes
Mar 2, 2022
ghengeveld
approved these changes
Mar 2, 2022
tmeasday
force-pushed
the
refactor-story-render
branch
from
338d516 to
761aea9
Compare
|
@tmeasday merge conflicts & CI errors. can you please take a look? |
|
@shilman I am still finishing this off after (in person) feedback from @ghengeveld |
tmeasday
force-pushed
the
17214-fix-duplicate-initial-render
branch
from
8214d06 to
b4f02bc
Compare
tmeasday
force-pushed
the
17214-fix-duplicate-initial-render
branch
from
b4f02bc to
0ded7eb
Compare
|
@tmeasday can you look into the failing unit tests? |
tmeasday
force-pushed
the
17214-fix-duplicate-initial-render
branch
from
0ded7eb to
539c868
Compare
shilman
changed the title
tmeasday
added a commit
that referenced
this pull request
Sep 1, 2022
Implementing #17599 for DocsRenderrs
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17214
Telescoping on #17598
What I did
Abort a render if
setCurrentStoryis called during itspreparingphase.How to test
See test, and original repro on issue.