CLI (React Native): ensure having an explicit dependency on prop-types

[Hypnosphi]

This is a follow-up to #1710
It's safer to have a direct dependency to anything you import from your code

[shilman]

@Hypnosphi great catch. i thought about this but got lazy .. thanks for picking up the slack!

Looks like prop-types wants to be in dependencies though, not devDependencies:

https://www.npmjs.com/package/prop-types

[codecov]

Codecov Report

Merging #1714 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1714   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files         252      252           
  Lines        5702     5702           
  Branches      683      685    +2     
=======================================
  Hits         1211     1211           
+ Misses       3970     3956   -14     
- Partials      521      535   +14

Impacted Files	Coverage Δ
addons/knobs/src/components/PropField.js	10.86% <0%> (ø)	⬆️
addons/info/src/components/Props.js	37.2% <0%> (ø)	⬆️
addons/knobs/src/components/types/Boolean.js	11.62% <0%> (ø)	⬆️
...es__/update-addon-info/update-addon-info.output.js	0% <0%> (ø)	⬆️
lib/ui/src/modules/ui/configs/handle_routing.js	28.04% <0%> (ø)	⬆️
lib/ui/src/modules/ui/containers/down_panel.js	23.52% <0%> (ø)	⬆️
lib/ui/src/modules/api/actions/api.js	50.47% <0%> (ø)	⬆️
addons/knobs/src/components/types/Object.js	5.81% <0%> (ø)	⬆️
addons/events/src/components/Event.js	0% <0%> (ø)	⬆️
...codemod/src/transforms/update-organisation-name.js	40.62% <0%> (ø)	⬆️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcff45...2188121. Read the comment docs.

[Hypnosphi]

@shilman Not in that particular case, as stories are part of development process, and the app/lib itself may not use prop-types. We add react-dom as devDep, too, and that's for a good reason

[tmeasday]

Do we need to do this for the other project types also? (i.e. React/Meteor)

[Hypnosphi]

No, as we don't have usages of prop-types in those templates

[shilman]

Gotcha, good call! 👍