-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MIGRATION instructions for Angular 13 / SB6.4 for Angular #16980
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 1daec22. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Added MIGRATION instructions for Angular 13 / SB6.4 for Angular
If you need storybook-specific styles separate from your app, you can configure the styles in the [SB Angular builder](#sb-angular-builder), which completely overrides your project's styles: | ||
|
||
```json | ||
"storybook": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman see #16950 (comment) -- I don't know if this is specific to the @nrwl/nx
set ups or not, but I specifically needed to put this in the build-storybook
stanza that follows, NOT the storybook
one here. I don't have time to update migration guide, sorry, but just a heads up for posterity and others searching until docs proper get updated.
"build": { | ||
"builder": "@angular-devkit/build-angular:browser", | ||
"options": { | ||
"styles": ["src/styles.css", "src/styles.scss"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would we use global SCSS in storybook with Angular 13 libraries? We're using the @nrwl/angular:package
executor from Nx workspaces. It doesn't have an option to add global style sheets.
Issue: #16950
What I did
Documented latest changes to Angular per various PRs and issue comments
How to test
N/A