Fix click event in Vue button example #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The story listens for a custom 'click' event emited from `MyButton.vue` component, but `MyButton.vue` lacks such a functionality. When the button is clicked, only an empty method is called. The change I suggested is the less intrusive one, keeping the method code as opposite to removing it and emitting an event directly from the template.
ndelangen
approved these changes
Aug 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
=========================================
Coverage ? 20.87%
=========================================
Files ? 251
Lines ? 5629
Branches ? 686
=========================================
Hits ? 1175
Misses ? 3913
Partials ? 541Continue to review full report at Codecov.
|
|
Thank you @gustojs for fixing this! Awesome! |
This was referenced Jan 12, 2018
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The Button story in Vue examples listens for a custom 'click' event emited from
MyButton.vuecomponent, butMyButton.vuelacks such a functionality. When the button is clicked, only an empty method is called.What I did
The change I suggested is the less intrusive one, keeping the method code as opposite to removing it and emitting an event directly from the template.