Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: update font family #1560

Merged
merged 2 commits into from
Aug 1, 2017
Merged

UI: update font family #1560

merged 2 commits into from
Aug 1, 2017

Conversation

Hypnosphi
Copy link
Member

Based on Slack discussion

-apple-system, ".SFNSText-Regular", "San Francisco", "Roboto",
"Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif
-apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu",
"Cantarell", "Fira Sans", "Droid Sans", "Arial", sans-serif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Helvetica Neue is still necessary for OS X 10.11 and below when not in Chrome:
https://bitsofco.de/the-new-system-font-stack/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't Arial be available there?

Copy link
Member

@danielduan danielduan Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. I think it's included to conform to the system's original styles and Arial is an unfamiliar and clunky looking font to Mac users.

Copy link
Member Author

@Hypnosphi Hypnosphi Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if the alternative is to have a font that jumps when going from normal to bold (and we have a menu in which it happens all the time), the unfamiliarity is a lesser evil

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm fair enough.

@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #1560 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   20.43%   20.46%   +0.02%     
==========================================
  Files         241      241              
  Lines        5250     5243       -7     
  Branches      649      647       -2     
==========================================
  Hits         1073     1073              
  Misses       3682     3682              
+ Partials      495      488       -7
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/theme.js 100% <ø> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 12% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66dce8...bdbae36. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 56919e4 into storybookjs:master Aug 1, 2017
@Hypnosphi Hypnosphi deleted the update-fonts branch August 1, 2017 16:40
@igor-dv
Copy link
Member

igor-dv commented Aug 2, 2017

When I mentioned changing the fonts is inconstant in the prev PR, I meant that IMO it's wrong to change this only in one place (lib/ui). This kind of theme is used in a few other places around this repo (for example addons), and styleguide-wise I think all the fonts should be the same (at least in the official addons / UI). But maybe I 'm too picky =) Anyway if it solves this jumping glitch - 👍 👍

@Hypnosphi Hypnosphi restored the update-fonts branch August 2, 2017 05:41
@Hypnosphi Hypnosphi deleted the update-fonts branch August 2, 2017 05:44
@Hypnosphi
Copy link
Member Author

Hypnosphi commented Aug 2, 2017

Well, in fact there isn't any consistensy of font-family across the codebase at the moment: https://github.com/storybooks/storybook/search?utf8=%E2%9C%93&q=fontFamily&type=

And if we want to make it more consistent, it would be better to use a shared theme instead of repeating ourselves. This can be a part of the major task of moving UI components to lib/components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants