-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo channel stubbing - causes NPM version errors to fail silently #1494
Conversation
Got @ndelangen 's approval over slack 🍷 |
Perhaps we should replace it with functions that throw useful errors to help people debug? function debugChannelError() {
throw new Error('Tried to access non-existant addons channel, see #1234 for details');
}
this.channel = { on: debugChannelError, emit: debugChannelError } |
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
=========================================
- Coverage 14.61% 14.6% -0.01%
=========================================
Files 202 202
Lines 4653 4655 +2
Branches 505 509 +4
=========================================
Hits 680 680
+ Misses 3545 3535 -10
- Partials 428 440 +12
Continue to review full report at Codecov.
|
@tmeasday updated per your suggestion |
lib/addons/src/index.js
Outdated
@@ -1,8 +1,14 @@ | |||
function channelError() { | |||
throw new Error('Tried to access non-existant addons channel, see issues #815 / #1374'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right: #1374 ?
Maybe we should make a FAQ entry? This doesn't seem like an issue that is going to go away :/
Is this mergable @tmeasday ? |
LGTM! |
Issue: #1486
What I did
Undo bad changes in PR
How to test
CI tests
(Or force a messed up NPM version error... has bitten many of us, but not sure the best way to repro)