Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix un-prefixed path links #14334

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Addon-docs: Fix un-prefixed path links #14334

merged 2 commits into from
Mar 26, 2021

Conversation

ndelangen
Copy link
Member

Issue: #13630

What I did

  • The href attribute (prop) was being modified (prefixed) by the Link component, but the click-handler didn't read this modification.

It seems the logical place to change/prefix the href would be in theaddons/docs/src/blocks/mdx.tsx code itself, but this is a fine solution that backwards compatible for now.

@ndelangen ndelangen requested a review from shilman March 25, 2021 09:04
@ndelangen ndelangen self-assigned this Mar 25, 2021
@ndelangen ndelangen added this to the 6.1.x milestone Mar 25, 2021
@shilman shilman changed the title FIX #13630 Addon-docs: Fix un-prefixed path links Mar 26, 2021
shilman
shilman approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

addons/docs/src/blocks/mdx.tsx Show resolved Hide resolved
@shilman shilman merged commit 9637904 into next Mar 26, 2021
@shilman shilman deleted the fix/13630-relative-links branch March 26, 2021 05:32
@shilman shilman mentioned this pull request Mar 26, 2021
Closed
@mgameover
Copy link

Hi @shilman,
Unfortunately, it doesn't solve the issue #13630
I added some comments to it, please take a look.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
addon: docs bug
Projects
None yet
Milestone
6.1.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @mgameover @shilman