CLI: Add --legacy-peer-deps for NPM7 install
#14106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
ndelangen
approved these changes
Mar 3, 2021
| @@ -15,8 +18,18 @@ export class NPMProxy extends JsPackageManager { | |||
| return `npm run ${command}`; | |||
| } | |||
|
|
|||
| getInstallArgs(): string[] { | |||
| if (!this.installArgs) { | |||
| const version = this.executeCommand('npm', ['--version']); | |||
There was a problem hiding this comment.
Wondering if you need some .trim() here?
There was a problem hiding this comment.
tested by hand -- doesn't seem to matter to semver, but good thought
shilman
changed the title
--legacy-peer-deps for NPM7 install--legacy-peer-deps for NPM7 install
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 3, 2021
CLI: Add `--legacy-peer-deps` for NPM7 install
This was referenced Mar 3, 2021
This was referenced Mar 7, 2021
Closed
This was referenced Mar 14, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12983
What I did
Add
--legacy-peer-depsfor NPM7 installsHow to test
See attached unit tests
I also tested it end-to-end in a sample app: