Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit storybook build non-zero on stats errors (e.g. errors in the transpilation pipeline) #1372

Merged
merged 4 commits into from
Jun 28, 2017
Merged

Exit storybook build non-zero on stats errors (e.g. errors in the transpilation pipeline) #1372

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3e7a0b
fix: Fail on transpilation errors
joscha Jun 28, 2017
302f157
Update build.js
joscha Jun 28, 2017
9c57ae0
factor into one if
joscha Jun 28, 2017
50aac05
allow guard
joscha Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/react/src/server/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ if (program.staticDir) {
// compile all resources with webpack and write them to the disk.
logger.log('Building storybook ...');
webpack(config).run((err, stats) => {
if (err) {
if (err || stats.hasErrors()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(err || stats.hasErrors()) {
  const errors = err ? [err] : stats.toJson().errors
  errors.forEach(...)
  process.exit(1)
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would not print the stats errors if there is a "normal" error - is that deliberate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, main point is that i think it should just be a single if statement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, changes in 9c57ae0

logger.error('Failed to build the storybook');
logger.error(err.message);
err && logger.error(err.message);
stats.hasErrors() && stats.toJson().errors.forEach(e => logger.error(e));
process.exit(1);
}

Expand Down