Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix shortcut button focus border to support high contrast #13699

Merged
merged 6 commits into from
Feb 25, 2021
Merged

UI: Fix shortcut button focus border to support high contrast #13699

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
81a238f
Fixes 13373 - changing to non shadow focus border for high contast ac…
micahgodbolt Jan 21, 2021
1637ee8
Update lib/ui/src/components/sidebar/Menu.tsx
micahgodbolt Feb 22, 2021
9a49546
Update Menu.tsx
micahgodbolt Feb 22, 2021
c54b570
Update Menu.tsx
micahgodbolt Feb 22, 2021
78d24ea
Merge branch 'next' into pr/13699
shilman Feb 25, 2021
7e32605
fix linting
shilman Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/ui/src/components/sidebar/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,17 @@ export const MenuButton = styled(Button)<MenuButtonProps>(({ highlighted, theme
padding: 7,
micahgodbolt marked this conversation as resolved.
Show resolved Hide resolved
'&:focus': {
background: theme.barBg,
boxShadow: `${theme.color.secondary} 0 0 0 1px inset`,
boxShadow: 'none',
},
'&:focus:before': {
micahgodbolt marked this conversation as resolved.
Show resolved Hide resolved
content: '""',
position: 'absolute',
top: 0,
bottom: 0,
left: 0,
right: 0,
borderRadius: '100%',
border: `1px solid ${theme.color.secondary}`,
},

...(highlighted && {
Expand Down