Svelte: Fix duplicate story preview #13663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
svelte
bug
patch:yes
shilman
changed the title
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jan 22, 2021
Svelte: Fix duplicate story preview
This was referenced Mar 8, 2021
Closed
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13662
What I did
HOC doesn't destroy it child component. There is probably memory/resources leak related to this issue.
The fix is simple here: using svelte:component/ instead of mounting manually the nested component.
How to test