Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Redux ui #1334

Closed
wants to merge 28 commits into from
Closed

[WIP] Redux ui #1334

wants to merge 28 commits into from

Conversation

alexandrebodin
Copy link
Contributor

Moving lib/ui to redux

What

I'm moving the ui to redux and adding some features in the meantime. This work is both an experiment and possibly sth we can merge later on.

Why

  • Will make contributions easier
  • Match the preview stack
  • This PR might give people an idea of the inner workings of storybook
  • Open discussions about APIs if needed :)

I'm mostly doing it to understand storybook better and see what we can improve or not ^^

@storybookbot
Copy link
Collaborator

storybookbot commented Jun 22, 2017

Fails
🚫

PR is marked with "do not merge" label.

🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@storybookjs storybookjs deleted a comment from codecov bot Jun 22, 2017
@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

Merging #1334 into master will decrease coverage by 4.48%.
The diff coverage is 4.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1334      +/-   ##
=========================================
- Coverage   14.35%   9.86%   -4.49%     
=========================================
  Files         201     229      +28     
  Lines        4613    5139     +526     
  Branches      506     601      +95     
=========================================
- Hits          662     507     -155     
- Misses       3508    4080     +572     
- Partials      443     552     +109
Impacted Files Coverage Δ
lib/ui/src/old/modules/ui/actions/ui.js 25% <ø> (ø)
lib/ui/src/old/modules/shortcuts/actions/index.js 0% <ø> (ø)
lib/ui/src/old/modules/ui/containers/down_panel.js 20% <ø> (ø)
lib/ui/src/new/components/LeftPanel/TextFilter.js 0% <ø> (ø)
lib/ui/src/new/components/Layout/dimensions.js 0% <ø> (ø)
lib/ui/src/new/components/theme.js 0% <ø> (ø)
lib/ui/src/old/compose.js 17.64% <ø> (ø)
lib/ui/src/old/modules/ui/containers/search_box.js 0% <ø> (ø)
...ib/ui/src/old/modules/ui/configs/handle_routing.js 27.84% <ø> (ø)
lib/ui/src/new/components/LeftPanel/Header.js 0% <ø> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa20f9...67b374b. Read the comment docs.

@ndelangen
Copy link
Member

@alexandrebodin Is this something you're still interested in? Do you need help?

I'm trying to get our # of PRs down a bit.

@alexandrebodin
Copy link
Contributor Author

@ndelangen You can close.

I'll still be working on this anyway ;)

@ndelangen
Copy link
Member

Awesome, because this does sounds like a good action to take. I'm really happy to have you on this! 🙇

@ndelangen ndelangen removed their request for review July 28, 2017 13:50
@ndelangen ndelangen deleted the redux-ui branch May 7, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants