Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix link not working cross origin #13022

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Addon-docs: Fix link not working cross origin #13022

merged 6 commits into from
Jan 11, 2021

Conversation

ndelangen
Copy link
Member

Issue: #12194

What I did

  • Make link relative, not lookup path from parent, since this doesn't work cross origin

@ndelangen ndelangen added the bug label Nov 5, 2020
@ndelangen ndelangen requested a review from ghengeveld November 5, 2020 14:07
@ndelangen ndelangen requested a review from tmeasday as a code owner November 5, 2020 14:07
@ndelangen ndelangen self-assigned this Nov 5, 2020
@ndelangen ndelangen changed the title FIX link nor working cross origin FIX link not working cross origin Nov 5, 2020
shilman
shilman requested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to test?

@ndelangen
Copy link
Member Author

ndelangen commented Nov 16, 2020 •
edited
Loading

@shilman All the links on this story should function correctly: /story/addons-docs-markdown-docs--page

they all seem to work for me

@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@stale stale bot removed the inactive label Jan 5, 2021
@ndelangen ndelangen requested a review from shilman January 5, 2021 09:20
@ndelangen
Copy link
Member Author

@shilman good to merge? shall we please release this in a patch?

@ndelangen ndelangen requested a review from usulpro as a code owner January 11, 2021 09:49
@shilman shilman changed the title FIX link not working cross origin Addon-docs: Fix link not working cross origin Jan 11, 2021
@shilman shilman added addon: docs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 11, 2021
@shilman shilman merged commit 6a76b44 into next Jan 11, 2021
@shilman shilman deleted the 12194/link-not-using-parent-location branch January 11, 2021 10:17
@shilman shilman mentioned this pull request Jan 11, 2021
Closed
shilman added a commit that referenced this pull request Jan 11, 2021
@shilman
Merge pull request #13022 from storybookjs/12194/link-not-using-paren…
3a068d0 
…t-location

Addon-docs: Fix link not working cross origin
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 12, 2021
@mgameover mgameover mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld Awaiting requested review from ghengeveld

@tmeasday tmeasday Awaiting requested review from tmeasday

@shilman shilman Awaiting requested review from shilman

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman