Server: Serialize Object controls as JSON over the wire #11703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonspalmer
commented
Jul 27, 2020
| case 'object': | ||
| // send objects as JSON strings | ||
| storyArgs[key] = JSON.stringify(argValue); | ||
| break; |
| @@ -34,7 +34,8 @@ | |||
| "colour": "deeppink", | |||
| "today": "Jan 20 2017 GMT+0", | |||
| "items": ["Laptop", "Book", "Whiskey"], | |||
| "nice": true | |||
| "nice": true, | |||
| "other": {"hair": "brown", "eyes": "blue"} | |||
There was a problem hiding this comment.
wasn't testing object controls in the example app
| @@ -6,6 +6,7 @@ | |||
| - style = `border: 2px dotted ${colour}; padding: 8px 22px; border-radius: 8px`; | |||
| - today = new Date(today); | |||
| - items = items.split(','); | |||
| - other = JSON.parse(other) | |||
There was a problem hiding this comment.
proves we have it as json that we can parse
This was referenced Nov 17, 2020
This was referenced Jun 23, 2023
This was referenced Nov 30, 2023
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix the serialization of objects as JSON over the wire that was missed in the refactor of knobs to controls #11658
Cleaned up some cruft along the way.