Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition: Fix syntax on no-cors #11491

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Composition: Fix syntax on no-cors #11491

merged 2 commits into from
Jul 10, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 10, 2020 •
edited
Loading

Issue: it's mode: 'no-cors' not cors: 'no-cors' - https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

@tmeasday tmeasday requested a review from ndelangen July 10, 2020 02:44
shilman
shilman approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman added this to the 6.0 composition milestone Jul 10, 2020
@shilman shilman changed the title Syntax on no-cors was incorrect Composition: Fix syntax on no-cors was incorrect Jul 10, 2020
@shilman shilman changed the title Composition: Fix syntax on no-cors was incorrect Composition: Fix syntax on no-cors Jul 10, 2020
@shilman shilman merged commit 297b024 into next Jul 10, 2020
@ndelangen ndelangen deleted the fix-cors-fetch branch July 10, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
bug composition
Projects
None yet
Milestone
6.0 composition
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman