Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix sb init in Yarn workspace environment #10985

Merged
merged 4 commits into from
Jun 1, 2020
Merged

CLI: Fix sb init in Yarn workspace environment #10985

merged 4 commits into from
Jun 1, 2020

Commits on May 29, 2020

  1. fix(cli): fix init command when run in a Yarn workspace env 

    Add `--ignore-workspace-root-check` to avoid Yarn error when adding dependencies to the workspace root.
    @gaetanmaisse
    gaetanmaisse committed May 29, 2020
    Configuration menu
    Copy the full SHA
    10b34ee View commit details
    Browse the repository at this point in the history

  2. fix(e2e): remove skip-install option from sb init command 

    Removed this option because it can hide some issues with dependency installation process of @storybook/cli.
For instance, missing Yarn flags needed to have the CLI working in Yarn workspaces.

Also, as `sb init` is now running `yarn/npm install` the resolution step has to be made before init Storybook.
    @gaetanmaisse
    gaetanmaisse committed May 29, 2020
    Configuration menu
    Copy the full SHA
    df73724 View commit details
    Browse the repository at this point in the history

  3. test(e2e): add a E2E test config for Yarn workspace env (based on React)

    @gaetanmaisse
    gaetanmaisse committed May 29, 2020
    Configuration menu
    Copy the full SHA
    0e0006e View commit details
    Browse the repository at this point in the history

  4. test(e2e): improve jobs assignment on CI nodes 

    With the previous algorithm, some nodes have no jobs assigned to them due to rounding consideration.
For example with 10 nodes and 13 jobs to assign:
 13 jobs / 10 nodes -> 1.3 jobs per node -> rounded to 2 -> only the 1st 6 nodes run 2 jobs, the 7th 1 job and the other 0 job.

Using a modulo ensures that each node will at least run 1 job.
    @gaetanmaisse
    gaetanmaisse committed May 29, 2020
    Configuration menu
    Copy the full SHA
    2345957 View commit details
    Browse the repository at this point in the history