Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Full Screen Mode shortcut for Mac doesn't work #872

Closed
shilman opened this issue Apr 15, 2017 · 1 comment
Closed

Toggle Full Screen Mode shortcut for Mac doesn't work #872

shilman opened this issue Apr 15, 2017 · 1 comment
Labels
bug ui

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by willowcheng
Thursday Apr 13, 2017 at 02:50 GMT
Originally opened as storybook-eol/storybook-ui#82

⌘ ⇧ F would cause error shown in below and doesn't work, while ⌃ ⇧ F works properly. Can be reproduced by HEAD commit of current master branch.

screen shot 2017-04-12 at 10 42 23 pm
@willowcheng
Copy link

Follow up with the issue, I found ⌘ ⇧ F works now to toggle fullscreen mode, but Go FullScreen button in the example would fail as shortcut is simulated where e.target is not defined.

Can be reproduced by c9afedc.

willowcheng added a commit to willowcheng/storybook that referenced this issue Apr 25, 2017
@willowcheng
Event target should exist to decide if input is focused
5ac79de 
Simple fix for storybookjs#872
This was referenced Jan 12, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shilman @danielduan @ndelangen @willowcheng