-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Standalone React Native Build #3224
Comments
Can you go into more detail? What do you think we should separate here? Storybook RN from the RN bundler? |
I want to be able to build a production mode RN app with the storybook UI that doesn’t need s server running.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Daniel Duan <notifications@github.com>
Sent: Friday, March 16, 2018 8:30:07 PM
To: storybooks/storybook
Cc: Sid; Author
Subject: Re: [storybooks/storybook] Feature Request - Standalone React Native Build (#3224)
Can you go into more detail? What do you think we should separate here? Storybook RN from the RN bundler?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3224 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AILVC6tLslAhbW2-J0P-Uvlu03-vsgMqks5tfBK_gaJpZM4St-R4>.
|
There's been discussions about separating the app from the desktop app. Main problem - the Storybook app state is on the browser side and communicates over websocket to the RN app. We will need to refactor that if we want to split it. Then, the concern here will be that addons like knobs will potentially not work anymore. If you'd like to help us, let's discuss. |
For sure, I’d be down to help. I’ve been using storybook for a while now. If I remember correctly, there didn’t use to be an in-app UI to change stories. You’d have to switch stories via the web UI to see the changes in the simulator. But there’s a drawer layout navigation now in the app. Of course things like knobs won’t work. I’m afraid I’ve not delved into the code yet.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Daniel Duan <notifications@github.com>
Sent: Friday, March 16, 2018 8:50:27 PM
To: storybooks/storybook
Cc: Sid; Author
Subject: Re: [storybooks/storybook] Feature Request - Standalone React Native Build (#3224)
There's been discussions about separating the app from the desktop app.
Main problem - the Storybook app state is on the browser side and communicates over websocket to the RN app. We will need to refactor that if we want to split it.
Then, the concern here will be that addons like knobs will potentially not work anymore.
If you'd like to help us, let's discuss.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3224 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AILVC7RZChv_4Tjn-kESUUoZn9agHJ-4ks5tfBeCgaJpZM4St-R4>.
|
Got this to work: index.js /* eslint-disable global-require */
import { AppRegistry } from 'react-native';
import { getStorybookUI, configure } from '@storybook/react-native';
configure(() => {
require('./stories');
}, module);
const StorybookUI = getStorybookUI({
port: 7007,
onDeviceUI: true
});
AppRegistry.registerComponent('8fit', () => StorybookUI);
export default StorybookUI; webpack.haul.storybook.js module.exports = (_, { module }) => ({
entry: './storybook/index.js',
module: {
...module,
rules: [
{
test: /\.js?$/,
exclude: '/node_modules/',
use: [
{
loader: 'babel-loader'
}
]
},
...module.rules
]
}
// any other haul config here.
}); For regular development:
Bundle standalone: |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Issue details
This is a feature request. I believe something similar for the web version already exists. To add context, this isn't for an Expo for CRNA app. Just wondering if there's possibility for an alternative to https://github.com/facebook/react-native/blob/master/scripts/react-native-xcode.sh
The text was updated successfully, but these errors were encountered: