Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.3 Addon Knobs is missing select #2209

Closed
danielduan opened this issue Nov 1, 2017 · 0 comments
Closed

3.3 Addon Knobs is missing select #2209

danielduan opened this issue Nov 1, 2017 · 0 comments
Assignees
@danielduan
Labels
addon: knobs bug good first issue
Milestone
v3.3.0

Comments

@danielduan
Copy link
Member

I think this is accidental, but we shouldn't be deprecating like this.

https://github.com/storybooks/storybook/blob/release/3.3/addons/knobs/src/index.js#L10
vs
https://github.com/storybooks/storybook/blob/master/addons/knobs/src/index.js#L48
@danielduan danielduan added this to the v3.3.0 milestone Nov 1, 2017
@danielduan danielduan self-assigned this Nov 2, 2017
danielduan added a commit that referenced this issue Nov 2, 2017
@danielduan
#2209 knobs refactor accidentally removed select
a5f3c38
@danielduan danielduan mentioned this issue Nov 2, 2017
Merged
Hypnosphi added a commit that referenced this issue Nov 2, 2017
@Hypnosphi
Merge pull request #2210 from storybooks/dd/knob-select
e365f8d 
#2209 knobs refactor accidentally removed select
@dependencies dependencies bot mentioned this issue Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielduan danielduan

Labels
addon: knobs bug good first issue
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
1 participant
@danielduan