Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story order changes after enabling storyStoreV7 #16767

Closed
yannbf opened this issue Nov 23, 2021 · 1 comment
Closed

Story order changes after enabling storyStoreV7 #16767

yannbf opened this issue Nov 23, 2021 · 1 comment
Assignees
@tmeasday
Labels
bug on-demand store

Comments

@yannbf
Copy link
Member

yannbf commented Nov 23, 2021 •
edited
Loading

Describe the bug
Here's the before/after setting the storyStoreV7 flag:
image

There is no storySorts defined in preview.js. Here's how the stories globs look like:

  stories: [
    '../src/docs/Introduction.stories.mdx',
    '../src/docs/*.stories.mdx',
    '../src/**/*.stories.@(js|jsx|ts|tsx)',
  ],

To Reproduce
Access this repo and set the flag:
https://github.com/yannbf/mealdrop/blob/feat/sb-6.4/.storybook/main.ts
tmeasday added a commit that referenced this issue Nov 25, 2021
@tmeasday
Sort globbed files for consistent ordering.
14c30cf 
For #16767

Apparently globby's order is non deterministic: sindresorhus/globby#131

I wasn't able to reproduce in our tests but definitely saw the behaviour in the issue.
@tmeasday tmeasday mentioned this issue Nov 25, 2021
Merged
1 task
@shilman
Copy link
Member

shilman commented Nov 26, 2021

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-rc.10 containing PR #16788 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmeasday tmeasday

Labels
bug on-demand store
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmeasday @shilman @yannbf