Bump eslint-plugin-react from 7.12.4 to 7.13.0 (#6728)

Bump eslint-plugin-react from 7.12.4 to 7.13.0
storybookjs · May 7, 2019 · dca1e14 · dca1e14 · vercel · May 7, 2019
2 parents 81ccc19 + 590f670
commit dca1e14
Show file tree

Hide file tree

Showing 10 changed files with 35 additions and 30 deletions.
diff --git a/addons/actions/src/containers/ActionLogger/index.tsx b/addons/actions/src/containers/ActionLogger/index.tsx
@@ -26,6 +26,8 @@ const safeDeepEqual = (a: any, b: any): boolean => {
 };
 
 export default class ActionLogger extends Component<ActionLoggerProps, ActionLoggerState> {
+  private mounted: boolean;
+
   constructor(props: ActionLoggerProps) {
     super(props);
 
@@ -73,8 +75,6 @@ export default class ActionLogger extends Component<ActionLoggerProps, ActionLog
     this.setState({ actions: [] });
   };
 
-  private mounted: boolean;
-
   render() {
     const { actions = [] } = this.state;
     const { active } = this.props;

diff --git a/addons/jest/src/hoc/provideJestResult.tsx b/addons/jest/src/hoc/provideJestResult.tsx
@@ -36,12 +36,16 @@ export interface HocState {
 
 const provideTests = (Component: React.ComponentType<InjectedProps>) =>
   class TestProvider extends React.Component<HocProps, HocState> {
+    stopListeningOnStory: () => void;
+
+    mounted: boolean;
+
+    state: HocState = {};
+
     static defaultProps = {
       active: false,
     };
 
-    state: HocState = {};
-
     componentDidMount() {
       this.mounted = true;
       const { api } = this.props;
@@ -68,10 +72,6 @@ const provideTests = (Component: React.ComponentType<InjectedProps>) =>
       this.setState({ kind, storyName, tests });
     };
 
-    stopListeningOnStory: () => void;
-
-    mounted: boolean;
-
     render() {
       const { active } = this.props;
       const { tests } = this.state;

diff --git a/lib/api/src/index.tsx b/lib/api/src/index.tsx
@@ -94,6 +94,10 @@ export type Props = Children & RouterData & ProviderData;
 class ManagerProvider extends Component<Props, State> {
   static displayName = 'Manager';
 
+  api: API;
+
+  modules: any[];
+
   constructor(props: Props) {
     super(props);
     const { provider, location, path, viewMode, storyId, navigate } = props;
@@ -199,10 +203,6 @@ class ManagerProvider extends Component<Props, State> {
     return false;
   }
 
-  api: API;
-
-  modules: any[];
-
   render() {
     const { children } = this.props;
     const value = {
@@ -229,17 +229,17 @@ interface SubState {
 }
 
 class ManagerConsumer extends Component<ConsumerProps<SubState, Combo>> {
-  constructor(props: ConsumerProps<SubState, Combo>) {
-    super(props);
-    this.dataMemory = props.filter ? memoize(10)(props.filter) : null;
-  }
-
   dataMemory?: (combo: Combo) => SubState;
 
   prevChildren?: ReactElement<any> | null;
 
   prevData?: SubState;
 
+  constructor(props: ConsumerProps<SubState, Combo>) {
+    super(props);
+    this.dataMemory = props.filter ? memoize(10)(props.filter) : null;
+  }
+
   render() {
     const { children, pure } = this.props;
 

diff --git a/lib/cli/generators/SFC_VUE/template/src/stories/index.stories.js b/lib/cli/generators/SFC_VUE/template/src/stories/index.stories.js
@@ -1,4 +1,4 @@
-/* eslint-disable react/react-in-jsx-scope, react/no-this-in-sfc */
+/* eslint-disable react/react-in-jsx-scope */
 
 import { storiesOf } from '@storybook/vue';
 import { action } from '@storybook/addon-actions';
@@ -32,5 +32,3 @@ storiesOf('Button', module)
       '<my-button @click="action"><span role="img" aria-label="so cool">😀 😎 👍 💯</span></my-button>',
     methods: { action: action('clicked') },
   }));
-
-/* eslint-enable react/react-in-jsx-scope */
diff --git a/lib/cli/generators/VUE/template/stories/index.stories.js b/lib/cli/generators/VUE/template/stories/index.stories.js
@@ -1,4 +1,4 @@
-/* eslint-disable react/react-in-jsx-scope, react/no-this-in-sfc */
+/* eslint-disable react/react-in-jsx-scope */
 
 import { storiesOf } from '@storybook/vue';
 import { action } from '@storybook/addon-actions';
@@ -31,5 +31,3 @@ storiesOf('Button', module)
     template: '<my-button @click="action">😀 😎 👍 💯</my-button>',
     methods: { action: action('clicked') },
   }));
-
-/* eslint-enable react/react-in-jsx-scope */
diff --git a/lib/components/src/tabs/tabs.tsx b/lib/components/src/tabs/tabs.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable react/no-multi-comp */
 import React, {
   Children,
   Component,

diff --git a/lib/ui/src/components/layout/mobile.js b/lib/ui/src/components/layout/mobile.js
@@ -122,7 +122,6 @@ const Bar = styled.nav(
   })
 );
 
-// eslint-disable-next-line react/no-multi-comp
 class Mobile extends Component {
   constructor(props) {
     super();

diff --git a/lib/ui/src/components/panel/panel.js b/lib/ui/src/components/panel/panel.js
@@ -44,7 +44,6 @@ SafeTab.defaultProps = {
   children: null,
 };
 
-// eslint-disable-next-line react/no-multi-comp
 const AddonPanel = React.memo(({ panels, actions, selectedPanel, panelPosition }) => (
   <Tabs
     absolute

diff --git a/lib/ui/src/components/sidebar/treeview/treeview.js b/lib/ui/src/components/sidebar/treeview/treeview.js
@@ -198,7 +198,6 @@ const getPropsForTree = memoize(50)(({ dataset, selectedId }) => {
   return { selected, roots, others };
 });
 
-// eslint-disable-next-line react/no-multi-comp
 class TreeState extends PureComponent {
   state = {
     // We maintain two sets of expanded nodes, so we remember which were expanded if we clear the filter

diff --git a/yarn.lock b/yarn.lock
@@ -10814,7 +10814,7 @@ eslint-plugin-prettier@^3.0.1:
   dependencies:
     prettier-linter-helpers "^1.0.0"
 
-eslint-plugin-react@7.12.4, eslint-plugin-react@^7.12.4:
+eslint-plugin-react@7.12.4:
   version "7.12.4"
   resolved "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.12.4.tgz#b1ecf26479d61aee650da612e425c53a99f48c8c"
   integrity sha512-1puHJkXJY+oS1t467MjbqjvX53uQ05HXwjqDgdbGBqf5j9eeydI54G3KwiJmWciQ0HTBacIKw2jgwSBSH3yfgQ==
@@ -10827,6 +10827,19 @@ eslint-plugin-react@7.12.4, eslint-plugin-react@^7.12.4:
     prop-types "^15.6.2"
     resolve "^1.9.0"
 
+eslint-plugin-react@^7.12.4:
+  version "7.13.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.13.0.tgz#bc13fd7101de67996ea51b33873cd9dc2b7e5758"
+  integrity sha512-uA5LrHylu8lW/eAH3bEQe9YdzpPaFd9yAJTwTi/i/BKTD7j6aQMKVAdGM/ML72zD6womuSK7EiGtMKuK06lWjQ==
+  dependencies:
+    array-includes "^3.0.3"
+    doctrine "^2.1.0"
+    has "^1.0.3"
+    jsx-ast-utils "^2.1.0"
+    object.fromentries "^2.0.0"
+    prop-types "^15.7.2"
+    resolve "^1.10.1"
+
 eslint-restricted-globals@^0.1.1:
   version "0.1.1"
   resolved "https://registry.npmjs.org/eslint-restricted-globals/-/eslint-restricted-globals-0.1.1.tgz#35f0d5cbc64c2e3ed62e93b4b1a7af05ba7ed4d7"
@@ -16271,7 +16284,7 @@ jsprim@^1.2.2:
     json-schema "0.2.3"
     verror "1.10.0"
 
-jsx-ast-utils@^2.0.1:
+jsx-ast-utils@^2.0.1, jsx-ast-utils@^2.1.0:
   version "2.1.0"
   resolved "https://registry.npmjs.org/jsx-ast-utils/-/jsx-ast-utils-2.1.0.tgz#0ee4e2c971fb9601c67b5641b71be80faecf0b36"
   integrity sha512-yDGDG2DS4JcqhA6blsuYbtsT09xL8AoLuUR2Gb5exrw7UEM19sBcOTq+YBBhrNbl0PUC4R4LnFu+dHg2HKeVvA==
@@ -23760,7 +23773,7 @@ resolve@1.10.0:
   dependencies:
     path-parse "^1.0.6"
 
-resolve@1.x, resolve@^1.1.4, resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.3.2, resolve@^1.3.3, resolve@^1.4.0, resolve@^1.5.0, resolve@^1.6.0, resolve@^1.8.1, resolve@^1.9.0:
+resolve@1.x, resolve@^1.1.4, resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.10.1, resolve@^1.3.2, resolve@^1.3.3, resolve@^1.4.0, resolve@^1.5.0, resolve@^1.6.0, resolve@^1.8.1, resolve@^1.9.0:
   version "1.10.1"
   resolved "https://registry.npmjs.org/resolve/-/resolve-1.10.1.tgz#664842ac960795bbe758221cdccda61fb64b5f18"
   integrity sha512-KuIe4mf++td/eFb6wkaPbMDnP6kObCaEtIDuHOUED6MNUo4K670KZUHuuvYPZDxNF0WVLw49n06M2m2dXphEzA==