FIX linting

.eslintignore

@@ -2,3 +2,5 @@ dist
 build
 coverage
 node_modules
+**/example/**
+**/demo/**

.eslintrc.js

@@ -32,9 +32,10 @@ module.exports = {
       singleQuote: true,
     }],
     quotes: ['warn', 'single'],
+    'class-methods-use-this': ignore,
     'arrow-parens': ['warn', 'as-needed'],
     'space-before-function-paren': ignore,
-    'import/no-extraneous-dependencies': [error, { devDependencies: true }],
+    'import/no-extraneous-dependencies': [error, { devDependencies: true, peerDependencies: true }],
     'import/prefer-default-export': ignore,
     'react/jsx-uses-react': error,
     'react/jsx-uses-vars': error,

packages/addon-info/src/components/Node.js

@@ -71,7 +71,7 @@ function getData(element) {
     children: null,
   };
 
-  if (typeof element == 'string') {
+  if (typeof element === 'string') {
     data.text = element;
     return data;
   }

packages/addon-info/src/components/Story.js

@@ -293,8 +293,6 @@ export default class Story extends React.Component {
         {propTables}
       </div>
     );
-
-    return;
   }
 
   render() {

packages/addon-knobs/package.json

@@ -15,6 +15,7 @@
   },
   "devDependencies": {
     "@kadira/storybook": "*",
+    "@kadira/storybook-addons": "*",
     "@types/node": "^7.0.12",
     "@types/react": "^15.0.21",
     "babel-cli": "^6.24.1",
@@ -26,6 +27,7 @@
     "babel-preset-es2015": "^6.24.1",
     "babel-preset-react": "^6.24.1",
     "babel-preset-stage-2": "^6.24.1",
+    "enzyme": "^2.8.2",
     "git-url-parse": "^6.2.2",
     "raw-loader": "^0.5.1",
     "react": "^15.5.4",
@@ -35,13 +37,14 @@
     "typescript-definition-tester": "^0.0.5"
   },
   "peerDependencies": {
-    "@kadira/storybook-addons": "*",
     "react": "*",
     "react-dom": "*"
   },
   "dependencies": {
+    "@kadira/storybook-addons": "*",
     "babel-runtime": "^6.23.0",
     "deep-equal": "^1.0.1",
+    "global": "^4.3.1",
     "insert-css": "^1.0.0",
     "moment": "^2.18.1",
     "prop-types": "^15.5.8",

packages/addon-knobs/src/KnobManager.js

@@ -1,7 +1,9 @@
+/* eslint no-underscore-dangle: 0 */
+
 import React from 'react';
+import deepEqual from 'deep-equal';
 import WrapStory from './components/WrapStory';
 import KnobStore from './KnobStore';
-import deepEqual from 'deep-equal';
 
 // This is used by _mayCallChannel to determine how long to wait to before triggering a panel update
 const PANEL_UPDATE_INTERVAL = 400;
@@ -41,7 +43,7 @@ export default class KnobManager {
     let knobStore = this.knobStoreMap[key];
 
     if (!knobStore) {
-      knobStore = this.knobStoreMap[key] = new KnobStore();
+      knobStore = this.knobStoreMap[key] = new KnobStore(); // eslint-disable-line
     }
 
     this.knobStore = knobStore;

packages/addon-knobs/src/components/WrapStory.js

@@ -1,3 +1,5 @@
+/* eslint no-underscore-dangle: 0 */
+
 import PropTypes from 'prop-types';
 import React from 'react';
 

packages/addon-knobs/src/components/types/Array.js

@@ -36,12 +36,7 @@ ArrayType.propTypes = {
   onChange: PropTypes.func,
 };
 
-ArrayType.serialize = function(value) {
-  return value;
-};
-
-ArrayType.deserialize = function(value) {
-  return value;
-};
+ArrayType.serialize = value => value;
+ArrayType.deserialize = value => value;
 
 export default ArrayType;

packages/addon-knobs/src/components/types/Boolean.js

@@ -34,13 +34,7 @@ BooleanType.propTypes = {
   onChange: PropTypes.func,
 };
 
-BooleanType.serialize = function(value) {
-  return String(value);
-};
-
-BooleanType.deserialize = function(value) {
-  if (!value) return false;
-  return value.trim() === 'true';
-};
+BooleanType.serialize = value => String(value);
+BooleanType.deserialize = value => (typeof value === 'string' ? value.match('true') : false);
 
 export default BooleanType;

packages/addon-knobs/src/components/types/Color.js

@@ -1,3 +1,4 @@
+import { document } from 'global';
 import PropTypes from 'prop-types';
 import React from 'react';
 import { SketchPicker } from 'react-color';
@@ -90,12 +91,7 @@ ColorType.propTypes = {
   onChange: PropTypes.func,
 };
 
-ColorType.serialize = function(value) {
-  return value;
-};
-
-ColorType.deserialize = function(value) {
-  return value;
-};
+ColorType.serialize = value => value;
+ColorType.deserialize = value => value;
 
 export default ColorType;

packages/addon-knobs/src/components/types/Date/index.js

@@ -42,12 +42,7 @@ DateType.propTypes = {
   onChange: PropTypes.func,
 };
 
-DateType.serialize = function(value) {
-  return String(value);
-};
-
-DateType.deserialize = function(value) {
-  return parseFloat(value);
-};
+DateType.serialize = value => String(value);
+DateType.deserialize = value => parseFloat(value);
 
 export default DateType;

packages/addon-knobs/src/components/types/Number.js

@@ -67,12 +67,7 @@ NumberType.propTypes = {
   onChange: PropTypes.func,
 };
 
-NumberType.serialize = function(value) {
-  return String(value);
-};
-
-NumberType.deserialize = function(value) {
-  return parseFloat(value);
-};
+NumberType.serialize = value => String(value);
+NumberType.deserialize = value => parseFloat(value);
 
 export default NumberType;

packages/addon-knobs/src/components/types/Object.js

@@ -83,13 +83,7 @@ ObjectType.propTypes = {
   onChange: PropTypes.func,
 };
 
-ObjectType.serialize = function(object) {
-  return JSON.stringify(object);
-};
-
-ObjectType.deserialize = function(value) {
-  if (!value) return {};
-  return JSON.parse(value);
-};
+ObjectType.serialize = object => JSON.stringify(object);
+ObjectType.deserialize = value => (value ? JSON.parse(value) : {});
 
 export default ObjectType;

packages/addon-knobs/src/components/types/Select.js

@@ -1,3 +1,5 @@
+/* eslint no-underscore-dangle: 0 */
+
 import PropTypes from 'prop-types';
 import React from 'react';
 
@@ -56,12 +58,7 @@ SelectType.propTypes = {
   onChange: PropTypes.func,
 };
 
-SelectType.serialize = function(value) {
-  return value;
-};
-
-SelectType.deserialize = function(value) {
-  return value;
-};
+SelectType.serialize = value => value;
+SelectType.deserialize = value => value;
 
 export default SelectType;

packages/addon-knobs/src/components/types/Text.js

@@ -37,12 +37,7 @@ TextType.propTypes = {
   onChange: PropTypes.func,
 };
 
-TextType.serialize = function(value) {
-  return value;
-};
-
-TextType.deserialize = function(value) {
-  return value;
-};
+TextType.serialize = value => value;
+TextType.deserialize = value => value;
 
 export default TextType;

packages/addon-notes/package.json

@@ -14,6 +14,7 @@
   },
   "devDependencies": {
     "@kadira/storybook": "*",
+    "@kadira/storybook-addons": "*",
     "babel-cli": "^6.5.0",
     "babel-core": "^6.5.0",
     "babel-loader": "^6.2.4",

packages/addon-options/manager.js

@@ -1,2 +1,3 @@
 const manager = require('./dist/manager');
+
 manager.init();

packages/addon-options/preview.js

@@ -1,3 +1,4 @@
 const preview = require('./dist/preview');
+
 exports.setOptions = preview.setOptions;
 preview.init();

packages/addon-options/src/manager/index.js

@@ -1,4 +1,3 @@
-import React from 'react';
 import addons from '@kadira/storybook-addons';
 import { ADDON_ID, EVENT_ID } from '../shared';
 

packages/addons/src/index.js

@@ -1,3 +1,5 @@
+/* eslint no-underscore-dangle: 0 */
+
 export class AddonStore {
   constructor() {
     this._loaders = {};

packages/channel-postmessage/package.json

@@ -14,6 +14,7 @@
   },
   "dependencies": {
     "@kadira/storybook-channel": "*",
+    "global": "^4.3.1",
     "json-stringify-safe": "^5.0.1"
   }
 }

packages/channel-postmessage/src/index.js

@@ -1,13 +1,11 @@
+/* eslint no-underscore-dangle: 0 */
+
+import { window, document } from 'global';
 import Channel from '@kadira/storybook-channel';
 import stringify from 'json-stringify-safe';
 
 export const KEY = 'storybook-channel';
 
-export default function createChannel({ page }) {
-  const transport = new PostmsgTransport({ page });
-  return new Channel({ transport });
-}
-
 export class PostmsgTransport {
   constructor(config) {
     this._config = config;
@@ -58,22 +56,26 @@ export class PostmsgTransport {
     return window.parent;
   }
 
-  _handleEvent(e) {
-    if (!e.data || typeof e.data !== 'string') {
+  _handleEvent(event) {
+    if (!event.data || typeof event.data !== 'string') {
       return;
     }
     let data;
     try {
-      data = JSON.parse(e.data);
-    } catch (e) {
-      return null;
+      data = JSON.parse(event.data);
+    } catch (error) {
+      data = null;
     }
     if (!data || typeof data !== 'object') {
-      return null;
+      return;
     }
-    const { key, event } = data;
+    const { key, event: eventData } = data;
     if (key === KEY) {
-      this._handler(event);
+      this._handler(eventData);
     }
   }
 }
+export default function createChannel({ page }) {
+  const transport = new PostmsgTransport({ page });
+  return new Channel({ transport });
+}

packages/channel-websocket/package.json

@@ -14,6 +14,7 @@
     "shelljs": "^0.7.3"
   },
   "dependencies": {
-    "@kadira/storybook-channel": "^1.0.1"
+    "@kadira/storybook-channel": "^1.0.1",
+    "global": "^4.3.1"
   }
 }

packages/channel-websocket/src/index.js

@@ -1,9 +1,7 @@
-import Channel from '@kadira/storybook-channel';
+/* eslint no-underscore-dangle: 0 */
 
-export default function createChannel({ url }) {
-  const transport = new WebsocketTransport({ url });
-  return new Channel({ transport });
-}
+import { WebSocket } from 'global';
+import Channel from '@kadira/storybook-channel';
 
 export class WebsocketTransport {
   constructor({ url }) {
@@ -59,3 +57,8 @@ export class WebsocketTransport {
     };
   }
 }
+
+export default function createChannel({ url }) {
+  const transport = new WebsocketTransport({ url });
+  return new Channel({ transport });
+}

packages/channel/src/index.js

@@ -1,3 +1,5 @@
+/* eslint no-underscore-dangle: 0 */
+
 export default class Channel {
   constructor({ transport }) {
     this._sender = this._randomId();

packages/channel/src/index.test.js

@@ -1,3 +1,5 @@
+/* eslint no-underscore-dangle: 0 */
+
 import Channel from './';
 
 describe('Channel', () => {

packages/decorator-centered/package.json

@@ -13,11 +13,17 @@
       "babelify"
     ]
   },
+  "peerDependencies": {
+    "react": "*",
+    "react-dom": "*"
+  },
   "devDependencies": {
     "babel-cli": "^6.24.1",
     "babel-core": "^6.24.1",
     "babel-preset-es2015": "^6.24.1",
     "babel-preset-react": "^6.24.1",
-    "babel-preset-stage-0": "^6.24.1"
+    "babel-preset-stage-0": "^6.24.1",
+    "react": "^15.5.4",
+    "react-dom": "^15.5.4"
   }
 }