Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core config #623

Closed
wants to merge 1 commit into from
Closed

Add core config #623

wants to merge 1 commit into from

Conversation

trajano
Copy link
Contributor

@trajano trajano commented Oct 16, 2024

This is needed to disable telemetry

Issue:

What I did

How to test

Please explain how to test your changes and consider the following questions

  • Does this need a new example in examples/expo-example?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

This is needed to disable telemetry
@trajano trajano requested a review from dannyhw as a code owner October 16, 2024 03:33
@dannyhw
Copy link
Member

dannyhw commented Oct 16, 2024

I think there might be some extra steps needed to make the config actually apply since this config for rn storybook is parsed manually by the generate script. Have you confirmed that telemetry is going out? And is it being turned off by this option?

@trajano
Copy link
Contributor Author

trajano commented Oct 16, 2024

Nope, I just saw Telemetry config in the documentation while I was doing the update and I was just expecting the typings for the config to be relatively the same. I am primarily putting it to disable the telemetry in case it is doing telemetry.

@dannyhw
Copy link
Member

dannyhw commented Oct 16, 2024

I will check this but it was my understanding that telemetry is not going out since its not explicitly implemented for rn storybook

@trajano
Copy link
Contributor Author

trajano commented Oct 16, 2024

Awesome, it would be nice to know in the documentation that it is not supported by RN storybook in case people have privacy concerns.

@dannyhw
Copy link
Member

dannyhw commented Oct 20, 2024

I'm fairly confident that no telemetry is going out from react native and this config would have no impact. If I find anything that contradicts that I will revisit this. Thanks for bringing it up though!

@dannyhw dannyhw closed this Oct 20, 2024
trajano added a commit to trajano/expo-experiments that referenced this pull request Oct 20, 2024
Not needed to disable telemetry as per discussion in
storybookjs/react-native#623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants