Skip to content

Commit

Permalink
fix: set initial story only when ready (#616)
Browse files Browse the repository at this point in the history
  • Loading branch information
@dannyhw
dannyhw authored Oct 10, 2024
1 parent 46920a7 commit cb5b160
Show file tree
Hide file tree
Showing 9 changed files with 57 additions and 58 deletions.
18 changes: 9 additions & 9 deletions examples/expo-example/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,24 @@
"@react-native-async-storage/async-storage": "1.23.1",
"@react-native-community/datetimepicker": "8.0.1",
"@react-native-community/slider": "4.5.2",
"@storybook/addon-essentials": "^8.3.1",
"@storybook/addon-interactions": "^8.3.1",
"@storybook/addon-links": "^8.3.1",
"@storybook/addon-essentials": "^8.3.5",
"@storybook/addon-interactions": "^8.3.5",
"@storybook/addon-links": "^8.3.5",
"@storybook/addon-ondevice-actions": "^8.3.5",
"@storybook/addon-ondevice-backgrounds": "^8.3.5",
"@storybook/addon-ondevice-controls": "^8.3.5",
"@storybook/addon-ondevice-notes": "^8.3.5",
"@storybook/addon-react-native-server": "0.0.6",
"@storybook/addon-react-native-web": "^0.0.22",
"@storybook/addon-webpack5-compiler-babel": "^3.0.3",
"@storybook/blocks": "^8.3.1",
"@storybook/builder-webpack5": "^8.3.1",
"@storybook/blocks": "^8.3.5",
"@storybook/builder-webpack5": "^8.3.5",
"@storybook/global": "^5.0.0",
"@storybook/react": "^8.3.1",
"@storybook/react": "^8.3.5",
"@storybook/react-native": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5",
"@storybook/react-webpack5": "^8.3.1",
"@storybook/test": "^8.3.1",
"@storybook/react-webpack5": "^8.3.5",
"@storybook/test": "^8.3.5",
"expo": "^51.0.34",
"history": "^5.3.0",
"querystring": "^0.2.1",
Expand All @@ -55,7 +55,7 @@
"react-native-svg": "15.2.0",
"react-native-web": "~0.19.10",
"react-router": "^6.26.2",
"storybook": "^8.3.1",
"storybook": "^8.3.5",
"ws": "^8.18.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/ondevice-actions/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"prepare": "tsc"
},
"dependencies": {
"@storybook/addon-actions": "^8.3.1",
"@storybook/core": "^8.3.1",
"@storybook/addon-actions": "^8.3.5",
"@storybook/core": "^8.3.5",
"@storybook/global": "^5.0.0",
"fast-deep-equal": "^2.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ondevice-backgrounds/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"dev": "tsc --watch"
},
"dependencies": {
"@storybook/core": "^8.3.1",
"@storybook/core": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/ondevice-controls/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"copyimages": "cross-env-shell cp -r src/components/color-picker/resources dist/components/color-picker/resources"
},
"dependencies": {
"@storybook/addon-controls": "^8.3.1",
"@storybook/core": "^8.3.1",
"@storybook/addon-controls": "^8.3.5",
"@storybook/core": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5",
"@storybook/react-native-ui": "^8.3.5",
"deep-equal": "^1.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/ondevice-notes/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dev": "tsc --watch"
},
"dependencies": {
"@storybook/core": "^8.3.1",
"@storybook/core": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5",
"react-native-markdown-display": "^7.0.2"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-ui/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
"typescript": "^5.3.3"
},
"dependencies": {
"@storybook/core": "^8.3.1",
"@storybook/react": "^8.3.1",
"@storybook/core": "^8.3.5",
"@storybook/react": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5",
"fuse.js": "^7.0.0",
"memoizerific": "^1.11.3",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"test:ci": "jest"
},
"dependencies": {
"@storybook/core": "^8.3.1",
"@storybook/core": "^8.3.5",
"@storybook/csf": "^0.1.1",
"@storybook/global": "^5.0.0",
"@storybook/react": "^8.3.1",
"@storybook/react": "^8.3.5",
"@storybook/react-native-theming": "^8.3.5",
"@storybook/react-native-ui": "^8.3.5",
"chokidar": "^3.5.1",
Expand All @@ -54,7 +54,7 @@
"react-native-swipe-gestures": "^1.0.5",
"react-native-url-polyfill": "^2.0.0",
"setimmediate": "^1.0.5",
"storybook": "^8.3.1",
"storybook": "^8.3.5",
"type-fest": "~2.19",
"util": "^0.12.4",
"ws": "^8.18.0"
Expand Down
11 changes: 5 additions & 6 deletions packages/react-native/src/View.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@ export class View {
.then(() => {
this._ready = true;
setReady(true);
initialStory.then((st) => {
self._preview.selectionStore.selectionSpecifier = st;

self._preview.selectSpecifiedStory();
});
})
.catch((e) => console.error(e));

Expand All @@ -240,12 +245,6 @@ export class View {

self._forceRerender = () => forceUpdate();

initialStory.then((st) => {
self._preview.selectionStore.selectionSpecifier = st;

self._preview.selectSpecifiedStory();
});

// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

Expand Down
64 changes: 32 additions & 32 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4410,7 +4410,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/addon-actions@npm:8.3.5, @storybook/addon-actions@npm:^8.3.1":
"@storybook/addon-actions@npm:8.3.5, @storybook/addon-actions@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/addon-actions@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4438,7 +4438,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/addon-controls@npm:8.3.5, @storybook/addon-controls@npm:^8.3.1":
"@storybook/addon-controls@npm:8.3.5, @storybook/addon-controls@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/addon-controls@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4474,7 +4474,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/addon-essentials@npm:^8.3.1":
"@storybook/addon-essentials@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/addon-essentials@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4505,7 +4505,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/addon-interactions@npm:^8.3.1":
"@storybook/addon-interactions@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/addon-interactions@npm:8.3.5"
dependencies:
Expand All @@ -4520,7 +4520,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/addon-links@npm:^8.3.1":
"@storybook/addon-links@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/addon-links@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4553,8 +4553,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/addon-ondevice-actions@workspace:packages/ondevice-actions"
dependencies:
"@storybook/addon-actions": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.1"
"@storybook/addon-actions": "npm:^8.3.5"
"@storybook/core": "npm:^8.3.5"
"@storybook/global": "npm:^5.0.0"
fast-deep-equal: "npm:^2.0.1"
typescript: "npm:^5.3.3"
Expand All @@ -4568,7 +4568,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/addon-ondevice-backgrounds@workspace:packages/ondevice-backgrounds"
dependencies:
"@storybook/core": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
typescript: "npm:^5.3.3"
peerDependencies:
Expand All @@ -4581,8 +4581,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/addon-ondevice-controls@workspace:packages/ondevice-controls"
dependencies:
"@storybook/addon-controls": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.1"
"@storybook/addon-controls": "npm:^8.3.5"
"@storybook/core": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
"@storybook/react-native-ui": "npm:^8.3.5"
cross-env: "npm:^7.0.3"
Expand All @@ -4605,7 +4605,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/addon-ondevice-notes@workspace:packages/ondevice-notes"
dependencies:
"@storybook/core": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
react-native-markdown-display: "npm:^7.0.2"
typescript: "npm:^5.3.3"
Expand Down Expand Up @@ -4689,7 +4689,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/blocks@npm:8.3.5, @storybook/blocks@npm:^8.3.1":
"@storybook/blocks@npm:8.3.5, @storybook/blocks@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/blocks@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4720,7 +4720,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/builder-webpack5@npm:8.3.5, @storybook/builder-webpack5@npm:^8.3.1":
"@storybook/builder-webpack5@npm:8.3.5, @storybook/builder-webpack5@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/builder-webpack5@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4781,7 +4781,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/core@npm:8.3.5, @storybook/core@npm:^8.3.1":
"@storybook/core@npm:8.3.5, @storybook/core@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/core@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -4945,8 +4945,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/react-native-ui@workspace:packages/react-native-ui"
dependencies:
"@storybook/core": "npm:^8.3.1"
"@storybook/react": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.5"
"@storybook/react": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
"@types/jest": "npm:^29.4.3"
"@types/react": "npm:~18.2.79"
Expand Down Expand Up @@ -4974,10 +4974,10 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/react-native@workspace:packages/react-native"
dependencies:
"@storybook/core": "npm:^8.3.1"
"@storybook/core": "npm:^8.3.5"
"@storybook/csf": "npm:^0.1.1"
"@storybook/global": "npm:^5.0.0"
"@storybook/react": "npm:^8.3.1"
"@storybook/react": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
"@storybook/react-native-ui": "npm:^8.3.5"
"@types/jest": "npm:^29.4.3"
Expand All @@ -4995,7 +4995,7 @@ __metadata:
react-native-url-polyfill: "npm:^2.0.0"
react-test-renderer: "npm:18.2.0"
setimmediate: "npm:^1.0.5"
storybook: "npm:^8.3.1"
storybook: "npm:^8.3.5"
tsup: "npm:^7.2.0"
type-fest: "npm:~2.19"
typescript: "npm:^5.3.3"
Expand All @@ -5013,7 +5013,7 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/react-webpack5@npm:^8.3.1":
"@storybook/react-webpack5@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/react-webpack5@npm:8.3.5"
dependencies:
Expand All @@ -5033,7 +5033,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/react@npm:8.3.5, @storybook/react@npm:^8.3.1":
"@storybook/react@npm:8.3.5, @storybook/react@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/react@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -5085,7 +5085,7 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/test@npm:8.3.5, @storybook/test@npm:^8.3.1":
"@storybook/test@npm:8.3.5, @storybook/test@npm:^8.3.5":
version: 8.3.5
resolution: "@storybook/test@npm:8.3.5"
dependencies:
Expand Down Expand Up @@ -9690,24 +9690,24 @@ __metadata:
"@react-native-community/datetimepicker": "npm:8.0.1"
"@react-native-community/slider": "npm:4.5.2"
"@react-native/babel-preset": "npm:^0.74.0"
"@storybook/addon-essentials": "npm:^8.3.1"
"@storybook/addon-interactions": "npm:^8.3.1"
"@storybook/addon-links": "npm:^8.3.1"
"@storybook/addon-essentials": "npm:^8.3.5"
"@storybook/addon-interactions": "npm:^8.3.5"
"@storybook/addon-links": "npm:^8.3.5"
"@storybook/addon-ondevice-actions": "npm:^8.3.5"
"@storybook/addon-ondevice-backgrounds": "npm:^8.3.5"
"@storybook/addon-ondevice-controls": "npm:^8.3.5"
"@storybook/addon-ondevice-notes": "npm:^8.3.5"
"@storybook/addon-react-native-server": "npm:0.0.6"
"@storybook/addon-react-native-web": "npm:^0.0.22"
"@storybook/addon-webpack5-compiler-babel": "npm:^3.0.3"
"@storybook/blocks": "npm:^8.3.1"
"@storybook/builder-webpack5": "npm:^8.3.1"
"@storybook/blocks": "npm:^8.3.5"
"@storybook/builder-webpack5": "npm:^8.3.5"
"@storybook/global": "npm:^5.0.0"
"@storybook/react": "npm:^8.3.1"
"@storybook/react": "npm:^8.3.5"
"@storybook/react-native": "npm:^8.3.5"
"@storybook/react-native-theming": "npm:^8.3.5"
"@storybook/react-webpack5": "npm:^8.3.1"
"@storybook/test": "npm:^8.3.1"
"@storybook/react-webpack5": "npm:^8.3.5"
"@storybook/test": "npm:^8.3.5"
"@testing-library/react-native": "npm:12.4.3"
"@types/react": "npm:~18.2.79"
"@types/react-test-renderer": "npm:18.0.7"
Expand All @@ -9729,7 +9729,7 @@ __metadata:
react-native-svg: "npm:15.2.0"
react-native-web: "npm:~0.19.10"
react-router: "npm:^6.26.2"
storybook: "npm:^8.3.1"
storybook: "npm:^8.3.5"
typescript: "npm:^5.3.3"
ws: "npm:^8.18.0"
languageName: unknown
Expand Down Expand Up @@ -17640,7 +17640,7 @@ __metadata:
languageName: node
linkType: hard

"storybook@npm:^8.3.1":
"storybook@npm:^8.3.5":
version: 8.3.5
resolution: "storybook@npm:8.3.5"
dependencies:
Expand Down

0 comments on commit cb5b160

Please sign in to comment.