Fix generated ESM, revamp build system #113
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ storybook-static/ | |
| build-storybook.log | ||
| package-lock.json | ||
| .DS_Store | ||
| .env | ||
| *.log | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import type { StorybookConfig } from '@storybook/svelte-vite'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| framework: '@storybook/svelte-vite', | ||
| stories: [ | ||
| '../stories/**/*.stories.svelte', | ||
| ], | ||
| addons: [ | ||
| '../dist/preset/index.js', | ||
| '@storybook/addon-essentials', | ||
| '@storybook/addon-interactions', | ||
| ], | ||
| }; | ||
| export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,9 +11,21 @@ | |
| "url": "https://github.com/storybookjs/addon-svelte-csf" | ||
| }, | ||
| "license": "MIT", | ||
|
Comment on lines
-14
to
-16
There was a problem hiding this comment. You say this works in storybook? What i know of the preset-loading mechanism in storybook is what when an addon-entry is added, storybook will try resolving Maybe with There was a problem hiding this comment. Yeah, But yes, working in Node 16+ with Storybook 7.1+ in the repo. |
||
| "type": "module", | ||
| "exports": { | ||
| ".": { | ||
| "svelte": "./dist/index.js", | ||
| "types": "./dist/index.d.ts" | ||
| }, | ||
| "./preset": { | ||
| "types": "./dist/preset/index.d.ts", | ||
| "default": "./dist/preset/index.js" | ||
| }, | ||
| "./manager": { | ||
| "types": "./dist/preset/manager.d.ts", | ||
| "default": "./dist/preset/manager.js" | ||
| } | ||
| }, | ||
| "files": [ | ||
| "dist/**/*", | ||
| "README.md", | ||
|
|
@@ -22,64 +34,64 @@ | |
| ], | ||
| "scripts": { | ||
| "clean": "rimraf ./dist", | ||
| "build": "svelte-package --input ./src --types", | ||
| "prepublish": "npm run clean && npm run build", | ||
| "test": "vitest run", | ||
| "chromatic": "chromatic --exit-zero-on-changes", | ||
| "coverage": "vitest run --coverage", | ||
| "lint": "eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives", | ||
| "storybook": "storybook dev --port 6006", | ||
| "start": "concurrently \"npm run storybook --quiet\" \"npm run build --watch\"", | ||
| "build-storybook": "sb build", | ||
| "release": "npm run build && auto shipit" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/runtime": "^7.22.6", | ||
| "dedent": "^1.2.0", | ||
| "fs-extra": "^11.1.1", | ||
| "magic-string": "^0.30.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@auto-it/released": "^10.32.6", | ||
| "@storybook/addon-actions": "^7.1.1", | ||
| "@storybook/addon-essentials": "^7.1.1", | ||
| "@storybook/addon-interactions": "^7.1.1", | ||
| "@storybook/client-api": "^7.1.1", | ||
| "@storybook/client-logger": "^7.1.1", | ||
| "@storybook/core-client": "^7.1.1", | ||
| "@storybook/core-server": "^7.1.1", | ||
| "@storybook/csf": "^0.1.1", | ||
| "@storybook/eslint-config-storybook": "^3.1.2", | ||
| "@storybook/jest": "^0.1.0", | ||
| "@storybook/svelte": "^7.1.1", | ||
| "@storybook/svelte-vite": "^7.1.1", | ||
| "@storybook/test-runner": "^0.11.0", | ||
| "@storybook/testing-library": "^0.2.0", | ||
| "@storybook/types": "^7.1.1", | ||
| "@sveltejs/package": "^2.2.0", | ||
| "@sveltejs/vite-plugin-svelte": "^2.4.2", | ||
| "@tsconfig/svelte": "^5.0.0", | ||
| "auto": "^10.43.0", | ||
| "chromatic": "^6.19.9", | ||
| "concurrently": "^8.2.0", | ||
| "eslint": "^7.17.0", | ||
| "eslint-plugin-storybook": "^0.6.12", | ||
| "jsdom": "^22.1.0", | ||
| "prettier": "^3.0.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "rimraf": "^3.0.2", | ||
| "storybook": "^7.1.1", | ||
| "svelte": "^4.0.0", | ||
| "svelte-jester": "^2.3.2", | ||
| "svelte-loader": "^3.1.7", | ||
| "typescript": "^5.1.6", | ||
| "vite": "^4.4.3", | ||
| "vitest": "^0.33.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@storybook/svelte": "^7.0.0", | ||
| "@storybook/theming": "^7.0.0", | ||
| "@sveltejs/vite-plugin-svelte": "^1.0.0 || ^2.0.0", | ||
| "svelte": "^3.50.0 || ^4.0.0", | ||
| "svelte-loader": "^3.1.2", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't all these
npm runbepnpm runinstead to use the correct package resolution, or am I misunderstanding something? Same for the lines inpackage.json?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was silly of me. Done in 4269195.