Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace @storybook/api with @storybook/manager-api #62

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

tetslee
Copy link

@tetslee tetslee commented May 28, 2024

Small fix for next time you update to storybook v8. It's based on the current v8 tag

@tetslee tetslee closed this May 28, 2024
@tetslee tetslee reopened this May 28, 2024
@literalpie
Copy link
Collaborator

There might be some confusion here. This is targeting the 'next' branch which isn't used anymore. I don't think the main branch has any references to @storybook/api

@tetslee tetslee changed the base branch from next to main June 13, 2024 15:41
@tetslee
Copy link
Author

tetslee commented Jun 13, 2024

@literalpie thanks, updated to main branch now.

Copy link
Collaborator

@literalpie literalpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't understand the purpose with your initial changes (with the bigger diff), but this is definitely a good fix! 🥇

@literalpie literalpie merged commit 1e062ac into storybookjs:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants