Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react peer dependency #253

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 30, 2025

Closes #246

  • removed react and react-dom as a peer-dependency requirement
  • pre-bundled @figspec/react

@valentinpalkovic valentinpalkovic added the patch Increment the patch version when merged label Jan 30, 2025
@valentinpalkovic valentinpalkovic self-assigned this Jan 30, 2025
@valentinpalkovic valentinpalkovic added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Jan 30, 2025
@valentinpalkovic valentinpalkovic merged commit 4012ffd into master Jan 30, 2025
2 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/remove-react-peer-dependency branch January 30, 2025 14:20
@maximLyakhov
Copy link

This PR broke import {Figma} from '@storybook/addon-designs/blocks' component in .mdx files.
Returning to 8.0.4 fixes issue.

@valentinpalkovic
Copy link
Contributor Author

Hi @maximLyakhov

can you please provide a minimal reproduction?

@maximLyakhov
Copy link

Hi @valentinpalkovic

Create single *.mdx file, paste following:

import {Figma} from '@storybook/addon-designs/blocks';
import {Meta, Title} from '@storybook/blocks';

<Meta title="Documentation/Styles/Colors" />

<Title> Colors </Title>

<Figma
  defaultCollapsed
  url="{{insert any valid figma link}}"
/>

@valentinpalkovic
Copy link
Contributor Author

And what's the error message?

@maximLyakhov
Copy link

@valentinpalkovic
Screenshot 2025-02-11 at 14 04 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove peer dependency on React
2 participants