Merge pull request #5 from storybooks/update-master-react-storybook

Merge branch 'master' of github.com:storybooks/react-storybook

packages/react-storybook/CONTRIBUTING.md

@@ -11,7 +11,35 @@ No software is bug free. So, if you got an issue, follow these steps:
   * Clear title (make is shorter if possible).
   * Describe the issue in clear language.
   * Share error logs, screenshots and etc.
-  * To speed up the issue fixing process, send us a sample repo with the issue you faced.
+  * To speed up the issue fixing process, send us a sample repo with the issue you faced:
+
+### Reproductions
+
+The best way to help figure out an issue you are having is to produce a minimal reproduction. A good way to do that is using Create React App:
+
+```bash
+npm install --global create-react-app getstorybook
+
+create-react-app reproduction
+cd reproduction
+getstorybook
+
+# make changes to try and reproduce the problem, such as adding components + stories
+npm start storybook
+
+# see if you can see the problem, if so, commit it:
+git init
+git add -A
+git commit -m "reproduction for issue #123"
+
+# create an new repository on github to host the reproduction, then:
+git remote add origin https://github.com/<your-username>/<repo-name>
+git push -u origin master
+```
+
+If you follow that process, you can then link to the github repository in the issue. See https://github.com/storybooks/react-storybook/issues/708#issuecomment-290589886 for an example.
+
+**NOTE**: If your issue involves a webpack config, create-react-app will prevent you from modifying the *app's* webpack config, however you can still modify storybook's to mirror your app's version of storybook. Alternatively, use `npm run eject` in the CRA app to get a modifiable webpack config.
 
 ## Pull Requests (PRs)
 
@@ -49,7 +77,7 @@ In order to test features you add, you may need to link the local copy of this r
 For that we need a sample project. Let's create it.
 
 ```sh
-npm i -g create-react-app getstorybook
+npm install --global create-react-app getstorybook
 create-react-app my-demo-app
 cd my-demo-app
 getstorybook

packages/react-storybook/src/client/manager/preview.js

@@ -21,7 +21,14 @@ class Preview extends Component {
   /* eslint-enable class-methods-use-this */
 
   render() {
-    return <iframe id="storybook-preview-iframe" style={iframeStyle} src={this.props.url} />;
+    return (
+      <iframe
+        id="storybook-preview-iframe"
+        style={iframeStyle}
+        src={this.props.url}
+        allowFullScreen
+      />
+    );
   }
 }