fix(helper): effects are not cleaned up in @storyblok/field-plugin/react #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johannes-lindgren
requested review from
eunjae-lee,
demetriusfeijoo and
Dawntraoz
BibiSebi
approved these changes
Oct 3, 2024
demetriusfeijoo
approved these changes
Oct 3, 2024
…ryblok-field-plugin-react
johannes-lindgren
deleted the
SHAPE-7192-effects-are-not-cleaned-up-in-storyblok-field-plugin-react
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In
@storyblok/field-plugin/react, the effects are not being cleaned up, because the cleanup function is not returned from theuseEffectcallback.I also don't see any cleanup in the Vue 3 helper, but I am not addressing this in this PR. (SHAPE-7195)
Why?
JIRA: SHAPE-7192
Effects must be cleaned up.
How to test? (optional)
The demo app uses
@storyblok/field-plugin/react:yarn workspace demo devThe app should work normally. You don't normally notice the lack of cleanup, but in local development mode, you'd see the effects run at least twice, and possibly even more if you're modifying the helper itself.