-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): set specific version of pnpm for monorepos #330
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! And also thanks for adding the test cases :D
I've left a feedback, but it's not a blocker.
@all-contributors please add @hoersamu for bug and code. |
I've put up a pull request to add @hoersamu! 🎉 |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks great ! :)
What?
Why?
fixes #329
How to test? (optional)
I validated the corepack fix on my machine and tested monorepo creation with all package managers.
I expanded the test for monorepo creation to validate the yarn config file changes.