Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): set specific version of pnpm for monorepos #330

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

hoersamu
Copy link
Contributor

@hoersamu hoersamu commented Jan 9, 2024

What?

  • Set specific version for pnpm in packageManager field in the package.json file when creating monorepos
  • Exclude yarn specific files from monorepos that do not use yarn

Why?

fixes #329

  • pnpm monorepo creation failed when pnpm is installed using Corepack. This issue was caused by the missing version of the packageManager in the package.json file
  • Even if the monorepo was created with a package manager other than yarn the yarn specific config files were copied to the target folder.

How to test? (optional)

I validated the corepack fix on my machine and tested monorepo creation with all package managers.
I expanded the test for monorepo creation to validate the yarn config file changes.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 9:25am

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! And also thanks for adding the test cases :D

I've left a feedback, but it's not a blocker.

@eunjae-lee eunjae-lee changed the title fix: set specific version of pnpm for monorepos fix(cli): set specific version of pnpm for monorepos Jan 9, 2024
@eunjae-lee
Copy link
Contributor

@all-contributors please add @hoersamu for bug and code.

Copy link
Contributor

@eunjae-lee

I've put up a pull request to add @hoersamu! 🎉

auto-merge was automatically disabled January 11, 2024 09:23

Head branch was pushed to by a user without write access

@hoersamu hoersamu requested a review from eunjae-lee January 11, 2024 09:25
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks great ! :)

@eunjae-lee eunjae-lee merged commit ba897a4 into storyblok:main Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multirepo pnpm install fails after creation
2 participants