Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): fix type errors in test helper #320

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix(common): fix type errors in test helper #320

merged 3 commits into from
Dec 1, 2023

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Nov 28, 2023 •
edited
Loading

What?

This PR fixes type errors from #307.

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 3:24pm

This was referenced Nov 28, 2023
Merged
Merged
@eunjae-lee
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 28, 2023
Closed
Closed
@eunjae-lee eunjae-lee force-pushed the EXT-2048-test-helper-for-field-plugin branch from 4bbec28 to 92ee8ad Compare November 30, 2023 14:06
@eunjae-lee eunjae-lee changed the title clean up test helper WIP fix(common): fix type errors in test helper Nov 30, 2023
@eunjae-lee eunjae-lee marked this pull request as ready for review November 30, 2023 15:21
@eunjae-lee eunjae-lee requested a review from BibiSebi November 30, 2023 15:26
BibiSebi
BibiSebi approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@BibiSebi BibiSebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 strong

@eunjae-lee eunjae-lee merged commit 35e0357 into EXT-2048-test-helper-for-field-plugin Dec 1, 2023
@eunjae-lee eunjae-lee deleted the test-helper-cleanup branch December 1, 2023 09:15
eunjae-lee added a commit that referenced this pull request Dec 1, 2023
@eunjae-lee
feat(common): add test helper (#307)
7d2f396 
* WIP

* chore(lib): release @storyblok/field-plugin@1.0.0 (#305)

* fix test and clean up

* renames

* fix(common): fix type errors in test helper (#320)

* clean up test helper WIP

* improve types

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BibiSebi BibiSebi BibiSebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjae-lee @BibiSebi