fix(common): adding unbuild dependency to fix type problems #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BibiSebi
commented
Nov 13, 2023
| @@ -41,7 +37,7 @@ function closeModal() { | |||
| <div class="container"> | |||
| <Counter | |||
| :count="plugin.data.content" | |||
| :onIncrease="() => plugin.actions.setContent(plugin.data.content + 1)" | |||
| @onIncrease="plugin.actions.setContent(plugin.data.content + 1)" | |||
There was a problem hiding this comment.
I needed to make some changes to fix typescript issues. I will attach a video to explain why there was a TS issue in vue3 template.
You can find more details here --> https://storyblok.slack.com/archives/C04P3JBHWHW/p1699883718219399
5 tasks
eunjae-lee
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR evolves around adding the unbuild js dependency to field-plugin and helpers to solve type-related problems found via arethetypeswrong.github.com
In this PR the output for field-plugin seems to be passing. However as soon as I added unbuild to react helper the tests for field-plugin/react are all failing.
UPDATE
after running
yarn build:helpersfrom the root package and moving vite to dependencies instead of devDependencies it is possible for me to build the helpers with no problems.Why?
JIRA: EXT-2052
How to test? (optional)
yarn install in the rootyarn build:helpersinside the root package stillattw --packinside the field plugin package --> attw is a CLI running the same testing as the 'arethetypeswrong.github.io' website