Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dioxus backend and Taproot (ECDSA in Bitcoin was a mistake) #26

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

storopoli
Copy link
Owner

@storopoli storopoli commented Feb 25, 2025

Closes #24, #25, #22.
Will tackle the "frontend" in a different PR

Also moves everything to Taproot. I'm done with ECDSA, it was a mistake to put ECDSA on bitcoin.

TODO

  • Function that sweeps funds from a P2TR-derived from a npub using the taproot_key_spend_signature_hash
    • Test
  • Function that sweeps funds from a P2TR-derived escrow address using the taproot_script_spend_signature_hash
    • Test
  • Both functions should use TapSighashType::All and the Prevouts should be fetched from a mempool/esplora backend (assumes that the address was only spent once, no address reuse)
  • Async function to broadcast_tx given a mempool/esplora backend.
  • Update README.md with Taproot, NUMS and Merkle Tree diagram.

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 9:26am

@storopoli storopoli changed the title feat: Dioxus backend feat: Dioxus backend and Taproot (ECDSA in Bitcoin was a mistake) Feb 25, 2025
@luisschwab luisschwab self-requested a review February 25, 2025 18:42
@luisschwab
Copy link
Collaborator

Concept ACK, we should've went this way from the beginning. Will review in a couple of days.

@storopoli
Copy link
Owner Author

Concept ACK, we should've went this way from the beginning. Will review in a couple of days.

The malleability of PKs killed ECDSA <> Nostr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Resolution address should be derived from participant's npub
2 participants