Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streams not computed #188

Merged
merged 5 commits into from
Jun 19, 2023
Merged

fix streams not computed #188

merged 5 commits into from
Jun 19, 2023

Conversation

pesekon2
Copy link
Collaborator

No description provided.

@pesekon2 pesekon2 added the bug Something isn't working label Jun 14, 2023
@pesekon2 pesekon2 requested a review from jerabekjak June 14, 2023 11:30
@pesekon2 pesekon2 self-assigned this Jun 14, 2023
@jerabekjak
Copy link
Member

6f2754e caused problems with consistency test because I changed a output file name to make more sense....

Copy link
Member

@jerabekjak jerabekjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge it @pesekon2

smoderp2d/providers/base/__init__.py Show resolved Hide resolved
@pesekon2
Copy link
Collaborator Author

@jerabekjak Thanks. Merging. I had to turn off tests for py2.7, but this is not connected to this issue, but to #194 instead.

@pesekon2 pesekon2 merged commit 71ceed0 into master Jun 19, 2023
@pesekon2 pesekon2 deleted the fix_streams_not_computed branch June 19, 2023 14:22
@landam
Copy link
Member

landam commented Jun 19, 2023

@pesekon2 This should be backported to release 1.0, right?

@landam landam added this to the Version 1.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants