This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Updates for bindings #393
Merged
Updates for bindings #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
force-pushed
the
master
branch
2 times, most recently
from
cf8dabf to
a5c00aa
Compare
added 4 commits
October 17, 2017 01:16
When implementing bindings such as in Ruby, allocating the download state within storj_bridge_resolve_file will avoid the need to allocate from within Ruby in way that Ruby garbage collection would be responsible for cleaning it up. In this case the state is cleaned up within the function, so it should also be allocated with the function.
This was referenced Oct 17, 2017
bryanchriswhite
approved these changes
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes signatures for
storj_bridge_revolve_fileandstorj_bridge_store_fileto allocate upload and download state and return a pointer to it.Alternative to solve issue raised in #391