This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
fix: full width image will move together when scrolling [SPMVP-5751] #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://storipress-media.atlassian.net/browse/SPMVP-5751
Root cause
圖片滿版時的寬度設定為
100vw
導致捲軸出現Purpose
修正文章圖片滿版時會超出右邊且可以捲動的問題
For who
How did you fix it?
取得 body width 並設為圖片滿版時的寬度
Production deployment notes
🎩 Tophat
Do a thorough 🎩. What is tophatting?
Consider testing:
🎩 Instructions
test in local
yarn postinstall
)yarn dev
Related PRs
Checklist before requesting review
// eslint-ignore-next-line <rule name>
on it)skipcq
comment)Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
E.g: Blocking feedback must be addressed before merging.
Gif (optional)