Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define ucan/revoke capability #943

Merged
merged 5 commits into from
Oct 6, 2023
Merged

feat: define ucan/revoke capability #943

merged 5 commits into from
Oct 6, 2023

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Oct 5, 2023

Define ucan/revoke capability

@Gozala Gozala requested a review from travis October 5, 2023 00:04
Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! a couple questions that could probably be clarified with more comments, and one suggested tweak, but good to merge

can: 'ucan/revoke',
/**
* With MUST be a DID of the UCAN issuer that is in the proof chain of the
* delegation been revoked.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this always the DID of the issuer of the "context CID" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is otherwise anyone could request a revocation. Put it differently that is how we infer context / scope CID, by walking up the chain and finding a proof that corresponds to with.

packages/capabilities/src/ucan.js Outdated Show resolved Hide resolved
@Gozala Gozala merged commit 5d957ef into main Oct 6, 2023
@Gozala Gozala deleted the feat/ucan/revoke branch October 6, 2023 20:35
travis pushed a commit that referenced this pull request Oct 10, 2023
🤖 I have created a release *beep* *boop*
---


##
[9.4.0](capabilities-v9.3.0...capabilities-v9.4.0)
(2023-10-10)


### Features

* define ucan/revoke capability
([#943](#943))
([5d957ef](5d957ef))
* upgrade to ucanto@9
([#951](#951))
([d72faf1](d72faf1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants