-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define ucan/revoke capability #943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! a couple questions that could probably be clarified with more comments, and one suggested tweak, but good to merge
can: 'ucan/revoke', | ||
/** | ||
* With MUST be a DID of the UCAN issuer that is in the proof chain of the | ||
* delegation been revoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this always the DID of the issuer of the "context CID" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is otherwise anyone could request a revocation. Put it differently that is how we infer context / scope CID, by walking up the chain and finding a proof that corresponds to with
.
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
🤖 I have created a release *beep* *boop* --- ## [9.4.0](capabilities-v9.3.0...capabilities-v9.4.0) (2023-10-10) ### Features * define ucan/revoke capability ([#943](#943)) ([5d957ef](5d957ef)) * upgrade to ucanto@9 ([#951](#951)) ([d72faf1](d72faf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Define
ucan/revoke
capability