fix: ucan log connect only when url and token #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/ucan-log-connect-only-when-url-and-token
branch
from
b3934de to
dc45e48
Compare
gobengo
approved these changes
Mar 23, 2023
vasco-santos
pushed a commit
that referenced
this pull request
Mar 23, 2023
🤖 I have created a release *beep* *boop* --- ## [5.1.2](access-api-v5.1.1...access-api-v5.1.2) (2023-03-23) ### Bug Fixes * ucan log connect only when url and token ([#607](#607)) ([5eef6cc](5eef6cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
We can only use `ucan-log` when we have URL and secret. This also enables us to ship prod of this module without prod of w3infra in place Co-authored-by: Benjamin Goering <171782+gobengo@users.noreply.github.com>
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.1.2](access-api-v5.1.1...access-api-v5.1.2) (2023-03-23) ### Bug Fixes * ucan log connect only when url and token ([#607](#607)) ([5ba86cb](5ba86cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](storacha/w3ui@react-v1.2.0...react-v1.3.0) (2023-12-08) ### Features * pin core dep to trigger a new release ([storacha#607](storacha/w3ui#607)) ([82fbd62](storacha/w3ui@82fbd62)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](storacha/w3ui@react-v1.2.0...react-v1.3.0) (2023-12-08) ### Features * pin core dep to trigger a new release ([storacha#607](storacha/w3ui#607)) ([cfbf61b](storacha/w3ui@cfbf61b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only use
ucan-logwhen we have URL and secret. This also enables us to ship prod of this module without prod of w3infra in place