chore: Feat/multi provider mergeback 1679556904 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it (#596) Motivation: * #593 * by removing this, [my other PR](#578) doesn't have to worry about this package anymore (I had to when I encountered some miniflare/wrangler/workers-types/etc type mismatches when adopting R2Bucket type) Notes * this removes some tests in access-client that tested against this access-ws running in miniflare. If we need those back, we can always checkout the things we want back from these commits. Putting #awake here so it shows up in repo search results * My understanding is that the websocket used by access-client agent is different than the access-ws package implemented
Motivation: * first PR on #571 todo * [x] initial `DbDelegationsStorageWithR2` that passes tests as a `DelegationsStorage` * [x] rm unused access-ws package #596 * [x] access-api should use `DbDelegationsStorageWithR2` and not `DbDelegationsStorage` (without r2) and still pass tests #599 informed by review * [x] add r2 bucket name binding to wrangler.toml for staging, production #578 (comment) unblocks: * `DbDelegationsStorageWithR2` supports deletes * we don't need this to support current `DelegationsStorage`, but probably will before long, but doesn't need to block this PR * optimization where r2 stores all the CIDs with varying multibases but for the same hash only once * safe to remove `DbDelegationsStorage`, `DelegationsV2Row`, `DelegationsV2Tables` --------- Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
alanshaw
approved these changes
Mar 23, 2023
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.1](storacha/w3ui@core-v1.1.0...core-v1.1.1) (2023-12-08) ### Bug Fixes * package.json explicitly wants w3up-client@11.2.1 ([storacha#606](storacha/w3ui#606)) ([ffa8d1a](storacha/w3ui@ffa8d1a)) * upgrade access client to incorporate fixed indexeddb store ([storacha#604](storacha/w3ui#604)) ([2eb8a20](storacha/w3ui@2eb8a20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.1](storacha/w3ui@core-v1.1.0...core-v1.1.1) (2023-12-08) ### Bug Fixes * package.json explicitly wants w3up-client@11.2.1 ([storacha#606](storacha/w3ui#606)) ([99d0c75](storacha/w3ui@99d0c75)) * upgrade access client to incorporate fixed indexeddb store ([storacha#604](storacha/w3ui#604)) ([2f981fd](storacha/w3ui@2f981fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: