fix: retry when PUT request fails #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
pushed a commit
that referenced
this pull request
Dec 5, 2024
🤖 I have created a release *beep* *boop* --- ## [17.1.2](upload-client-v17.1.1...upload-client-v17.1.2) (2024-12-05) ### Fixes * retry when PUT request fails ([#1601](#1601)) ([be2f05f](be2f05f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
added a commit
to storacha/upload-service
that referenced
this pull request
Dec 6, 2024
FML, we have a useless retry function that does not retry the PUT request when fetch response is non-200. Not any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FML, we have a useless retry function that does not retry the PUT request when fetch response is non-200.
Not any more.