-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
description of beta migration #139
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be web3.storage instead of nft.storage ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for NFT.Storage, so people who are looking for free NFT storage know what to do. Maybe the wording needs to be more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but isn't this true for web3.storage also ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically we will treat all account as web3 storage accounts unless the user tell us they are nft.storage accounts. @dchoi27 mind looking at the verbiage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be more confusing to the user if we tell them existing web3.storage uploads will be migrated to w3up, rather than w3up uploads getting migrated to web3.storage (from their perspective, it should be one and the same). Let's go with something like:
During the beta period, uploads via w3up will only appear via the beta APIs, and not on the web3.storage or NFT.Storage websites, even if the associated email addresses are the same.
At the end of the beta period, web3.storage and NFT.Storage's upload APIs and existing accounts will be upgraded to use w3up. Uploads via the w3up beta be migrated to web3.storage by default and, if applicable, combined with the relevant existing web3.storage account (based on email address). If you would rather have your beta w3up account be associated with the NFT.Storage product (e.g., you are only storing off-chain NFT data), please email us at
support@nft.storage
. All w3up uploads associated with a given registered email will only be able to be associated with one of either web3.storage or NFT.Storage when these uploads are migrated.