Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: filecoin-client github workflow runs arethetypesworking tooling, passes due to removal of chain-tracker export #1014

Merged
merged 3 commits into from
Oct 25, 2023
Merged

ci: filecoin-client github workflow runs arethetypesworking tooling, passes due to removal of chain-tracker export #1014

merged 3 commits into from
Oct 25, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Oct 25, 2023 •
edited
Loading

Motivation:

Change

  • now CI for filecoin-client will use attw to prevent releases like this that dont pass attw check
  • also update package.json to resolve the attw update for filecoin-client

@gobengo gobengo changed the title filecoin-client github workflow runs arethetypesworking tooling ci: filecoin-client github workflow runs arethetypesworking tooling Oct 25, 2023
@gobengo gobengo mentioned this pull request Oct 25, 2023
Closed
@gobengo gobengo changed the title ci: filecoin-client github workflow runs arethetypesworking tooling ci: filecoin-client github workflow runs arethetypesworking tooling, passes due to removal of chain-tracker export Oct 25, 2023
@gobengo gobengo merged commit 58bc17f into main Oct 25, 2023
4 checks passed
@gobengo gobengo deleted the attw-1698259173 branch October 25, 2023 19:40
@gobengo
Copy link
Contributor Author

gobengo commented Oct 25, 2023

I should have done this with a 'fix' prefix in order to trigger release please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

@travis travis Awaiting requested review from travis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gobengo @alanshaw