Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storybook #267

Merged
merged 2 commits into from
Jan 18, 2023
Merged

feat: add storybook #267

merged 2 commits into from
Jan 18, 2023

Conversation

olizilla
Copy link
Contributor

Add storybook scaffolding so we can iterate on our components and all the states they can be in.

Screenshot 2023-01-18 at 16 58 32

Uses the beta release of storybook v7 as it has support for pnpm.

Part of #225 - we need this to demonstrate out components in all their possible states so we can make them good.

License: MIT
Signed-off-by: Oli Evans oli@protocol.ai

Add storybook scaffolding so we can iterate on our components and all the states they can be in.

Uses the beta release of storybook v7 as it has support for pnpm.

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9d659d:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@olizilla
Copy link
Contributor Author

Using context for all the properties of our components makes it harder to set them up in storybook. We might want to export basic UI components so we can just pass in state as props and make it easier the styling part easier to iterate on.

storybook expects us to statically configure Args that would be passed in as props to our components, but we have to use the escape hatch of the render fn, as demo'd in this PR to configure a context instead of passing in props.

@travis travis merged commit 7150c8c into main Jan 18, 2023
@travis travis deleted the storybook branch January 18, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants