Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React UI Authenticator container styles impact on child layouts even when logged in. #351

Closed
olizilla opened this issue Feb 2, 2023 · 0 comments · Fixed by #352
Closed

React UI Authenticator container styles impact on child layouts even when logged in. #351

olizilla opened this issue Feb 2, 2023 · 0 comments · Fixed by #352

Comments

@olizilla
Copy link
Contributor

olizilla commented Feb 2, 2023 •
edited
Loading

We're applying a set of style to .w3ui-authenticator to allow us to show a full screen "not logged in" contsainer.

https://github.com/web3-storage/w3ui/blob/0c661c6f4d28776b4ac7ad1aea3e0958186f8480/packages/react/src/styles/authenticator.css#L22-L28

That root class remains in the tree even when you are logged in, which forces the applications layout to deal with being a flex child, and contained in a height:100vh parent element.

The logged in UI should not have to deal with layout choices of the authenticator log in screen. Related to #349
olizilla added a commit that referenced this issue Feb 2, 2023
@olizilla
fix: remove authenticator class when registed
9742501 
only include the `w3ui-authenticator` class in the dom when we want to show the log in box.

otherwise the layout we choose for the register form is inherited by the logged in app layout which is undesirable

fixes #351

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla olizilla mentioned this issue Feb 2, 2023
Merged
olizilla added a commit that referenced this issue Feb 3, 2023
@olizilla
fix: remove authenticator class when registed (#352)
3668f3b 
only include the `w3ui-authenticator` class in the dom when we want to
show the log in box.

otherwise the layout we choose for the register form is inherited by the
logged in app layout which is undesirable

fixes #351

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@olizilla
fix: remove authenticator class when registed (storacha#352)
e115f9f 
only include the `w3ui-authenticator` class in the dom when we want to
show the log in box.

otherwise the layout we choose for the register form is inherited by the
logged in app layout which is undesirable

fixes storacha/w3ui#351

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove authenticator class when registed storacha/w3ui
1 participant
@olizilla