refactor: remove UCAN stream handler and insert deltas directly into …

…space-diff table (#458) This PR addresses the objectives outlined in the issue storacha/project-tracking#304 Please refer to the issue for detailed context. **TODO**: - [x] Remove `ucan-stream` (billing) - [x] Insert space usage delta into the diff table in `register` - [x] Insert space usage delta into the diff table in `deregister` - [x] Use `TransactWriteItems` to ensure atomic write transactions - [x] Ensure tests are passing
storacha · Feb 11, 2025 · 3f5fdb3 · 3f5fdb3
1 parent 7b9d425
commit 3f5fdb3
Show file tree

Hide file tree

Showing 13 changed files with 310 additions and 753 deletions.
diff --git a/billing/functions/ucan-stream.js b/billing/functions/ucan-stream.js
diff --git a/billing/lib/api.ts b/billing/lib/api.ts
@@ -336,8 +336,6 @@ export interface UcanWorkflowMessage<C extends Capabilities = Capabilities> exte
   type: 'workflow'
 }
 
-export type UcanStreamMessage<C extends Capabilities = Capabilities> = UcanWorkflowMessage<C> | UcanReceiptMessage<C>
-
 // Utility ////////////////////////////////////////////////////////////////////
 
 export type ConsumerDID = DID

diff --git a/billing/lib/ucan-stream.js b/billing/lib/ucan-stream.js
diff --git a/billing/test/helpers/context.js b/billing/test/helpers/context.js
@@ -148,24 +148,6 @@ export const createStripeTestContext = async () => {
   return { customerStore }
 }
 
-export const createUCANStreamTestContext = async () => {
-  await createAWSServices()
-
-  const spaceDiffTableName = await createTable(awsServices.dynamo.client, spaceDiffTableProps, 'space-diff-')
-  const spaceDiffStore = createSpaceDiffStore(awsServices.dynamo.client, { tableName: spaceDiffTableName })
-  const consumerTableName = await createTable(awsServices.dynamo.client, consumerTableProps, 'consumer-')
-  const consumerStore = {
-    ...createConsumerStore(awsServices.dynamo.client, { tableName: consumerTableName }),
-    ...createStorePutterClient(awsServices.dynamo.client, {
-      tableName: consumerTableName,
-      validate: validateConsumer, // assume test data is valid
-      encode: encodeConsumer
-    })
-  }
-
-  return { consumerStore, spaceDiffStore }
-}
-
 /**
  * @returns {Promise<import('../lib/api.js').EgressTrafficTestContext>}
  */

diff --git a/billing/test/lib.ucan-stream.spec.js b/billing/test/lib.ucan-stream.spec.js
diff --git a/billing/test/lib/api.ts b/billing/test/lib/api.ts
@@ -47,12 +47,6 @@ export interface StripeTestContext {
   customerStore: CustomerStore
 }
 
-export interface UCANStreamTestContext {
-  spaceDiffStore: SpaceDiffStore
-  consumerStore: ConsumerStore & StorePutter<Consumer>
-}
-
-
 export interface EgressTrafficTestContext extends Context {
   egressTrafficQueue: EgressTrafficQueue & QueueRemover<EgressTrafficData>
   egressTrafficQueueUrl: string
@@ -74,7 +68,6 @@ export type TestContext =
   & CustomerBillingQueueTestContext
   & SpaceBillingQueueTestContext
   & StripeTestContext
-  & UCANStreamTestContext
   & EgressTrafficTestContext
 
 /** QueueRemover can remove items from the head of the queue. */