Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filecoin spec aggregate accept receipt type #83

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Oct 23, 2023

Fixes aggregate/accept receipt:

  1. inclusion proof was wrongly here. It should only be in piece/accept because it is piece specific proof within an aggregate
  2. added aggregate in receipt to be coherent with other receipts for */accept

Fixes filecoin/accept receipt:

  1. added piece and aggregate in receipt to be coherent with other receipts for */accept
  2. swaped aux to be a property per refactor: filecoin api services events and tests w3up#974 (comment)

@vasco-santos vasco-santos merged commit e469e57 into main Oct 23, 2023
@vasco-santos vasco-santos deleted the fix/filecoin-spec-aggregate-accept-receipt branch October 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants