Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow release-plz to open changelog PRs #31

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: allow release-plz to open changelog PRs #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ jobs:
node-version: 18
cache: 'npm'
- run: npm ci
- run: npm run build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is redundant here, now we call it from prepare it happens as part of npm ci

- run: npm run lint

test:
needs: check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can run check and test in parallel.

runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -38,10 +36,14 @@ jobs:

release:
if: (github.event_name == 'push' && github.ref == 'refs/heads/main')
needs: test
needs:
- test
- check
runs-on: ubuntu-latest
permissions:
id-token: write
contents: write
pull-requests: write
Comment on lines +45 to +46
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoping it fix like https://github.com/google-github-actions/release-please-action/issues/709

steps:
- uses: actions/checkout@v4
- uses: google-github-actions/release-please-action@v3
Expand Down